Skip to content

[TRTLLM-15040][test] Prune legacy Llama and Nemotron tests - #17858

Open
xinhe-nv wants to merge 20 commits into
NVIDIA:mainfrom
xinhe-nv:trtllm-15040
Open

[TRTLLM-15040][test] Prune legacy Llama and Nemotron tests#17858
xinhe-nv wants to merge 20 commits into
NVIDIA:mainfrom
xinhe-nv:trtllm-15040

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Remove out-of-scope model-specific coverage while retaining generic KV-cache, LoRA, and architecture validation on supported Llama assets.

Summary

  • Removed legacy Llama, Nemotron, DeciLM, and unsupported model-specific coverage.
  • Retained generic KV-cache, LoRA, speculative decoding, and architecture validation.
  • Updated model paths, registries, accuracy references, performance configurations, fixtures, and integration test lists.
  • Replaced legacy Llama KV-cache coverage with Qwen3 and Qwen3 LoRA scenarios.
  • Replaced legacy Llama LoRA coverage with Llama 3.1 FP8/BF16 coverage.
  • Updated Spark coverage with Qwen3, Nemotron Nano, and GPT-OSS cases.

Dev Engineer Review

  • Verify that removed model paths and registry entries are not referenced by retained tests or deployment workflows.
  • Verify consistency across .pre-commit-config.yaml, legacy-files.txt, ruff-legacy.toml, and ruff-legacy-baseline.json.
  • Verify Qwen3 KV-cache V2 coverage for correctness, chunked prefill, eviction, block reuse, overlap scheduling, partial reuse, and LoRA scenarios.
  • Verify that Llama 3.1 model paths, adapter paths, adapter names, ranks, and cache settings match available test assets.
  • Verify configuration values, test paths, and test-list entries.
  • Check for regression gaps caused by removed model-specific coverage.
  • CI run #67048 and L0_MergeRequest_PR pipeline #54589 failed. No fix or rerun result was provided.

QA Engineer Review

  • Added or updated Llama 3.1 LoRA, speculative decoding, API, memory profiling, metrics, and Qwen3 KV-cache tests.
  • Removed Nemotron NAS, DeciLM, legacy Llama, and obsolete model-specific tests.
  • Updated QA lists: llm_function_core.txt, llm_spark_core.txt, llm_spark_func.yml, and llm_spark_perf.yml.
  • Updated test-db lists: l0_a10.yml, l0_a30.yml, l0_b200.yml, l0_dgx_b200.yml, l0_dgx_h100.yml, l0_dgx_h200.yml, and l0_gb200_multi_gpus.yml.
  • Removed obsolete entries from tests/integration/test_lists/waives.txt.
  • Several modified and added test functions do not have explicit test-list coverage mapping in the supplied changes.
  • Verdict: needs follow-up.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@xinhe-nv
xinhe-nv force-pushed the trtllm-15040 branch 2 times, most recently from 135699a to 5e042fe Compare August 18, 2026 06:50
@xinhe-nv
xinhe-nv marked this pull request as ready for review August 18, 2026 06:50
@xinhe-nv
xinhe-nv requested review from a team as code owners August 18, 2026 06:50
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@xinhe-nv
xinhe-nv requested a review from Wanli-Jiang August 18, 2026 06:50
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Remove the retired model-specific LoRA test while preserving maintained LoRA coverage.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Require the temperature-zero Qwen3 DraftTarget test to match the full greedy token sequence so later-token divergences cannot pass unnoticed.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Replace cross-run text comparison with direct runtime schedule validation so shape-sensitive BF16 ties do not make the A100 test flaky.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Validate every runtime observation against the production resolver while requiring the designed transition points without assuming an exhaustive transition list.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70325 [ run ] triggered by Bot. Commit: 925be22 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70325 [ run ] completed with state FAILURE. Commit: 925be22
/LLM/main/L0_MergeRequest_PR pipeline #57564 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

xinhe-nv commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70507 [ run ] triggered by Bot. Commit: 925be22 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70507 [ run ] completed with state FAILURE. Commit: 925be22
/LLM/main/L0_MergeRequest_PR pipeline #57727 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

xinhe-nv commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70580 [ run ] triggered by Bot. Commit: 925be22 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70580 [ run ] completed with state SUCCESS. Commit: 925be22
/LLM/main/L0_MergeRequest_PR pipeline #57788 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

xinhe-nv commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70615 [ run ] triggered by Bot. Commit: 925be22 Link to invocation

Comment thread tests/unittest/metrics/test_collector.py
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70615 [ run ] completed with state SUCCESS. Commit: 925be22
/LLM/main/L0_MergeRequest_PR pipeline #57819 completed with status: 'UNSTABLE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@xinhe-nv

xinhe-nv commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70666 [ reuse-pipeline ] triggered by Bot. Commit: 925be22 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70666 [ reuse-pipeline ] completed with state SUCCESS. Commit: 925be22
Can't reuse PR_Github #70615 with status: FAILED

Link to invocation

@xinhe-nv

xinhe-nv commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70861 [ run ] triggered by Bot. Commit: 925be22 Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.