[None][infra] Remove stale perf-sanity waives orphaned by #17609 - #17785
Conversation
PR NVIDIA#17609 de-enrolled a batch of perf/test_perf_sanity.py::test_e2e DeepSeek-V3.2 / Kimi-K2.5 cases from the test-db perf_sanity lists but left their entries in waives.txt. Those 18 entries now reference tests that exist in no L0 or QA list, so the "Check Test List" stage fails on every PR with "Non-existent test name in l0 or qa list found in waives.txt". Remove the orphaned entries. Their nvbug SKIPs are moot now that the tests no longer run. Verified: no perf_sanity waive references a non-existent list entry after this change; AST validation and the duplicate-waives check both pass. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. WalkthroughThe integration waiver list removes obsolete performance skips and adds updated GB300 skips for DeepSeek V4 Pro, GLM-5, DeepSeek-R1, and GPT-OSS configurations. ChangesIntegration waiver maintenance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized cleanup removes obsolete test waivers without changing runtime code or behavior, and no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #66577 [ run ] triggered by Bot. Commit: |
|
PR_Github #66577 [ run ] completed with state
|
|
/bot skip --comment "waive only PR" |
|
PR_Github #66588 [ skip ] triggered by Bot. Commit: |
|
PR_Github #66588 [ skip ] completed with state |
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com> Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
Description
PR #17609 de-enrolled a batch of
perf/test_perf_sanity.py::test_e2eDeepSeek-V3.2 / Kimi-K2.5 cases from thetest-dbperf_sanity lists but left their entries intests/integration/test_lists/waives.txt. Those 18 entries now reference tests that exist in no L0 or QA list, so the Check Test List stage (scripts/check_test_list.py --l0 --qa --waive) fails with:This change removes the 18 orphaned entries. Their nvbug SKIPs are moot now that the referenced tests no longer run.
Why this escaped CI
Merge skew between two independently-green PRs:
waives.txt. Its gating pipeline validated a tree that did not contain both the list removals and the pre-existing waives together, so nothing checked them as a unit before merge.The result only surfaces on a subsequent PR that runs Check Test List fresh (no stage reuse), which is why it was not caught at #17609 merge time and why unrelated PRs get flagged for it.
Test Coverage
No new code paths. Validated locally:
scripts/check_test_list.py --validate(AST list validation) passes.scripts/check_test_list.py --check-duplicate-waivesreports no duplicates.PR Checklist