Skip to content

[None][infra] Remove stale perf-sanity waives orphaned by #17609 - #17785

Merged
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:infra/cleanup-stale-perf-sanity-waives
Aug 17, 2026
Merged

[None][infra] Remove stale perf-sanity waives orphaned by #17609#17785
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:infra/cleanup-stale-perf-sanity-waives

Conversation

@brnguyen2

@brnguyen2 brnguyen2 commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Description

PR #17609 de-enrolled a batch of perf/test_perf_sanity.py::test_e2e DeepSeek-V3.2 / Kimi-K2.5 cases from the test-db perf_sanity lists but left their entries in tests/integration/test_lists/waives.txt. Those 18 entries now reference tests that exist in no L0 or QA list, so the Check Test List stage (scripts/check_test_list.py --l0 --qa --waive) fails with:

Non-existent test name in l0 or qa list found in waives.txt: perf/test_perf_sanity.py::test_e2e[...]

This change removes the 18 orphaned entries. Their nvbug SKIPs are moot now that the referenced tests no longer run.

Why this escaped CI

Merge skew between two independently-green PRs:

The result only surfaces on a subsequent PR that runs Check Test List fresh (no stage reuse), which is why it was not caught at #17609 merge time and why unrelated PRs get flagged for it.

Test Coverage

No new code paths. Validated locally:

  • scripts/check_test_list.py --validate (AST list validation) passes.
  • scripts/check_test_list.py --check-duplicate-waives reports no duplicates.
  • Confirmed no remaining perf_sanity waive references a test absent from the active L0/QA lists.

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

PR NVIDIA#17609 de-enrolled a batch of perf/test_perf_sanity.py::test_e2e
DeepSeek-V3.2 / Kimi-K2.5 cases from the test-db perf_sanity lists but
left their entries in waives.txt. Those 18 entries now reference tests
that exist in no L0 or QA list, so the "Check Test List" stage fails on
every PR with "Non-existent test name in l0 or qa list found in
waives.txt".

Remove the orphaned entries. Their nvbug SKIPs are moot now that the
tests no longer run. Verified: no perf_sanity waive references a
non-existent list entry after this change; AST validation and the
duplicate-waives check both pass.

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f50218b2-1ef7-48c2-8e9c-e1caa640be6e

📥 Commits

Reviewing files that changed from the base of the PR and between a098858 and c42fdcd.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


Walkthrough

The integration waiver list removes obsolete performance skips and adds updated GB300 skips for DeepSeek V4 Pro, GLM-5, DeepSeek-R1, and GPT-OSS configurations.

Changes

Integration waiver maintenance

Layer / File(s) Summary
Performance waiver entries
tests/integration/test_lists/waives.txt
Removed obsolete DeepSeek V3.2, GB200, and Kimi K2.5 skips. Added updated GB300 aggregate and disaggregated skips for DeepSeek V4 Pro, GLM-5, DeepSeek-R1, and GPT-OSS.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c42fd

This localized cleanup removes obsolete test waivers without changing runtime code or behavior, and no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the infrastructure cleanup and removal of stale performance-test waivers orphaned by issue #17609.
Description check ✅ Passed The description explains the issue, root cause, solution, validation steps, and checklist status with sufficient detail for this cleanup change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66577 [ run ] triggered by Bot. Commit: c42fdcd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66577 [ run ] completed with state FAILURE. Commit: c42fdcd
/LLM/main/L0_MergeRequest_PR pipeline #54207 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive only PR"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66588 [ skip ] triggered by Bot. Commit: c42fdcd Link to invocation

@brnguyen2
brnguyen2 enabled auto-merge (squash) August 17, 2026 01:56
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66588 [ skip ] completed with state SUCCESS. Commit: c42fdcd
Skipping testing for commit c42fdcd

Link to invocation

@brnguyen2
brnguyen2 merged commit 988ae8b into NVIDIA:main Aug 17, 2026
16 checks passed
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Aug 17, 2026
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Aug 17, 2026
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Aug 17, 2026
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Aug 17, 2026
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Aug 17, 2026
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Aug 17, 2026
NVIDIA#17785)

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
yihwang-nv pushed a commit to yihwang-nv/TensorRT-LLM that referenced this pull request Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants