[https://nvbugs/6550708][test] Unwaive Cosmos3 distilled unit tests fixed by #17212 - #17722
Conversation
Four tests in test_cosmos3_distilled.py were waived after NVIDIA#16814 made BasePipeline.denoise() call self._profile_denoise_steps(), which the Cosmos3 test double lacked because it builds its pipeline through object.__new__ and so never got a _profiler attribute. NVIDIA#17212 fixed that on 2026-08-03 by stubbing _profiler=VisualGenProfiler() in _denoise_ready_pipeline(), the helper all four tests go through, but the waivers were left behind. Remove them so the distilled denoise loop is covered again. No source changes. Signed-off-by: Igor Shovkun <ishovkun@nvidia.com>
|
/bot run --disable-fail-fast |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe change removes four skipped Cosmos3 distilled visual-generation tests from the integration test waivers list. Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change re-enables four previously fixed Cosmos3 unit tests without altering production code or runtime behavior; no actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #66382 [ run ] triggered by Bot. Commit: |
|
PR_Github #66382 [ run ] completed with state |
…ixed by NVIDIA#17212 (NVIDIA#17722) Signed-off-by: Igor Shovkun <ishovkun@nvidia.com>
…ixed by NVIDIA#17212 (NVIDIA#17722) Signed-off-by: Igor Shovkun <ishovkun@nvidia.com>
Dev Engineer Review
tests/integration/test_lists/waives.txt._profiler=VisualGenProfiler()fixture fix restores the affected tests.QA Engineer Review
test-db/orqa/.tests/integration/test_lists/waives.txt.Description
#16814 replaced the
enumerate(timesteps)loop inBasePipeline.denoise()withself._profile_denoise_steps(...), which made_profilermandatory for the shareddenoise loop. The Cosmos3 unit-test double builds its pipeline through
object.__new__, so it never had that attribute, and four tests intests/unittest/_torch/visual_gen/test_cosmos3_distilled.pybegan failing with:They were waived under https://nvbugs/6550708 on 2026-08-02.
#17212 fixed the fixture on 2026-08-03 by stubbing
_profiler=VisualGenProfiler()in_denoise_ready_pipeline()— the helper all four tests go through — but the fourwaiver lines were never removed, so the tests have stayed off for roughly ten days
after their bug was fixed.
This PR deletes those four lines from
tests/integration/test_lists/waives.txt.No source changes, and no other waiver is touched.
Test Coverage
The four tests being re-enabled:
TestDistilledDenoiseLoop::test_guidance_one_single_forward_per_stepTestDistilledDenoiseLoop::test_scheduler_step_kwargs_reach_every_stepTestDistilledConditioningAnchor::test_every_forward_sees_clean_conditioned_frameTestDistilledConditioningAnchor::test_without_anchor_the_conditioned_frame_driftsThey guard the distilled Cosmos3 denoise loop: exactly one forward per step at
guidance_scale=1.0,scheduler_step_kwargs(which carries the seeded generator forper-step SDE noise) reaching every step, and the conditioning anchor keeping frame 0
clean across the loop. That path has no other working CI coverage today — its
end-to-end LPIPS gate does not execute because its checkpoint is missing from CI's
LLM_MODELS_ROOT(tracked separately).unittest/_torch/visual_gen/test_cosmos3_distilled.pyis listed intests/integration/test_lists/test-db/l0_b200.ymlunderstage: pre_merge, backend: pytorch, so this PR's own pipeline exercises the four tests; results will beconfirmed
PASSEDrather thanSKIPPEDbefore merge.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.