[None][fix] Correct MiniMax-M3 Eagle draft sub-page pool bound - #17656
Merged
zheyuf merged 1 commit intoAug 17, 2026
Merged
Conversation
Signed-off-by: Zheyu Fu <zheyuf@nvidia.com>
zheyuf
force-pushed
the
fix/minimax-m3-eagle-draft-subpage-bound
branch
from
August 17, 2026 18:07
dea01d3 to
b09f72c
Compare
4 tasks
zheyuf
marked this pull request as ready for review
August 17, 2026 18:40
zheyuf
requested review from
VALLIS-NERIA,
kris1025,
nvpohanh and
yunruis
and removed request for
a team,
VALLIS-NERIA,
kris1025,
nvpohanh and
yunruis
August 17, 2026 18:40
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #66836 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #66836 [ run ] completed with state |
brb-nv
pushed a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
Aug 25, 2026
…A#17656) Signed-off-by: Zheyu Fu <zheyuf@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
This PR fix the cold start AL regression for Minimax-m3 eagle. It's a functionality fix but not a perf boost. No extra overhead is added.
MiniMax-M3 uses a shared KV cache for the target model and the Eagle3 draft model. The target uses 128-token pages, while the draft model views the same memory as 32-token pages.
During cold start, the draft view reported the wrong number of available cache pages. Some valid draft pages could therefore be treated as out of range, causing the draft model to read incorrect KV data. The target model still verified the output, so final answers remained correct, but Eagle acceptance length dropped to roughly 1.8-2.0 and speculative decoding became less effective.
What changed
The draft view now calculates its cache boundary from its own 32-token layout instead of reusing the target manager's 128-token value.
This PR only fixes that boundary calculation. The aggregated shared-KV routing and performance changes are handled separately in #17835.
Result
Three independent cold starts recovered first-round acceptance length:
Mean acceptance length was 3.390. Cold generation time improved from 13.407 s to 10.946 s on average, an 18.4% reduction. Hot runs showed no regression.
Validation
13 passed.PR checklist
[JIRA/NVBUG/None][type]format