Skip to content

[None][fix] fix mypy error in sampler_strategy.py #17638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weiminwang-nv wants to merge 1 commit into from
Closed

[None][fix] fix mypy error in sampler_strategy.py #17638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorrt_llm/_torch/pyexecutor/sampler/sampler_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def sample(
logits,
beam_width_in=cast(int, beam_width_in),
beam_width_out=cast(int, beam_width_out),
row_stride=cast(int, row_stride),
row_stride=row_stride,
beam_search_args=group_metadata,
temperature=cast(float, temperature),
early_stopping=cast(int, early_stopping),
Expand Down Expand Up @@ -1341,7 +1341,7 @@ def sample_grouped_strategies(
# variable-beam-width step; the op slices down to the live beams.
rows_per_request = beam_width_in
if strategies and strategies[0][0] == "beam_search":
rows_per_request = cast(BeamSearch, strategies[0]).row_stride
rows_per_request = strategies[0].row_stride

@BowenFu BowenFu Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17601 already provides the complete typed-pattern fix across this function, while #17637 carries the alternative suppression. Could this PR be closed or rebased after one approach lands instead of adding a third, partial implementation?

assert logits.size(0) == rows_per_request * len(strategies)
else:
assert group_logit_indices.size(0) == beam_width_in * len(strategies)
Expand Down
Loading