[None][fix] Remove obsolete GPT-OSS two-model Eagle3 tests - #17597
Conversation
Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe change removes two GPT-OSS tests for two-model Eagle3 KV cache manager behavior. One-model Eagle3 V2 coverage remains. ChangesGPT-OSS Eagle3 test cleanup
Estimated code review effort: 1 (Trivial) | ~3 minutes Mergeability Score: ⚪ Minimal · up to This change removes obsolete tests without altering production behavior, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #65776 [ run ] triggered by Bot. Commit: |
|
PR_Github #65776 [ run ] completed with state |
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when NVIDIA#17366 forced 2-model spec-dec to fall back to 1-model, so the test was deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when NVIDIA#17366 forced 2-model spec-dec to fall back to 1-model, so the test was deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
…r exists) The waive entry pointed at unittest/_torch/modeling/test_modeling_gpt_oss.py::test_gpt_oss_two_model_eagle3_falls_back_to_v1, which was removed from main as obsolete in NVIDIA#17597 (commit 8398196). The 2-model Eagle3 fallback scenario it asserted was invalidated when deleted rather than fixed. Waiving a nonexistent test fails the AST-based validate-test-lists pre-commit hook (check_test_list.py --validate) and gates the whole pipeline. NVBug 6606544 is moot now that the test is gone. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
Dev Engineer Review
QA Engineer Review
test_gpt_oss_two_model_eagle3_falls_back_to_v1()test_gpt_oss_explicit_v2_rejects_two_model_eagle3()tests/integration/test_lists/files changed.Description
Two GPT-OSS KV-cache tests still exercised the deprecated two-model Eagle3 path after two-model speculative decoding was disabled. Since
eagle3_one_model=Falseis now ignored and normalized to the supported one-model configuration, the old V1 fallback and explicit-V2 rejection assertions no longer represent reachable behavior.Remove the obsolete two-model tests. Existing tests continue to cover GPT-OSS KV-cache V2 selection, explicit user settings, and supported one-model Eagle3 behavior.
Test Coverage
N/A - test removal only
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.