[None][fix] Reword Cosmos3 negative prompt terms that trip the guardrail blocklist by ishovkun · Pull Request #17523 · NVIDIA/TensorRT-LLM

ishovkun · 2026-08-11T21:57:22Z

Description

Two words in the shipped Cosmos3 negative prompts (negative_prompt.py and
cosmos3_negative_prompt.json) are on the Cosmos guardrail's custom blocklist:
"bleeding" (in "color bleeding between elements", a rendering artifact
description) and "lifeless" (in "the scene feels lifeless and sterile").
Out of 623 unique words in the prompt, these are the only two flagged — neither
is profanity. They are presumably on the blocklist as violence-adjacent words.

Any request that passes a negative prompt explicitly is blocked before
generation. The Cosmos3 example script (cosmos3.py) does this by default, so
the documented workflow fails every time guardrails are enabled — even with the
model-card caption as the positive prompt, which passes cleanly.

Fix: reword to "color smearing between elements" and "feels inert and sterile". Both replacements were validated against the real blocklist before
applying; all pass with zero flagged words.

Full CosmosSafetyChecker (blocklist + Qwen3Guard) verified on both prompts
after rewording — both return safe.

This is a follow-up to #17510 (which makes a blocked request return cleanly);
this PR prevents legitimate prompts from being blocked in the first place.

Test Coverage

No automated test is added: CI runs with TRTLLM_DISABLE_COSMOS3_GUARDRAILS=1
and cosmos_guardrail is not installed in CI, so a test asserting "the shipped
negative prompts pass the guardrail" cannot run there.

Verified manually instead:

Word-level blocklist scan — enumerated all 623 unique words in each prompt
against Blocklist.censor_prompt; zero flagged after rewording.
Full CosmosSafetyChecker.check_text_safety() (blocklist + Qwen3Guard) on
json.dumps(COSMOS3_VIDEO_NEGATIVE_PROMPT) and on the examples JSON, loaded
the same way cosmos3.py loads it — both return safe.

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…ail blocklist Two words in the shipped negative prompts are on the Cosmos guardrail's custom blocklist: "bleeding" (in "color bleeding between elements", a rendering artifact) and "lifeless" (in "the scene feels lifeless and sterile"). Out of 623 unique words in the prompt these are the only two flagged, and neither is profanity. Any request passing a negative prompt explicitly is therefore blocked before generation. The example script does exactly that, so the documented workflow fails every time guardrails are enabled. Reword to "color smearing" and "feels inert and sterile"; both clear the blocklist with no flagged words remaining. Signed-off-by: Igor Shovkun <ishovkun@nvidia.com>

coderabbitai · 2026-08-11T21:59:24Z

Walkthrough

The Cosmos3 negative prompts now use “color smearing” for three subject appearance entries and “inert” for the aesthetics mood description in both JSON and Python definitions.

Changes

Cosmos3 prompt wording

Layer / File(s)	Summary
Synchronize negative prompt wording `examples/visual_gen/models/cosmos3/cosmos3_negative_prompt.json`, `tensorrt_llm/_torch/visual_gen/models/cosmos3/negative_prompt.py`	The three subject appearance descriptions replace “color bleeding” with “color smearing.” The aesthetics mood description replaces “lifeless” with “inert.”

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies a fix to Cosmos3 negative prompt terms that trigger the guardrail blocklist.
Description check	✅ Passed	The description explains the issue, solution, validation, test limitations, and checklist status in sufficient detail.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

ishovkun · 2026-08-11T22:03:10Z

/bot run

ishovkun · 2026-08-11T22:04:19Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-11T22:09:12Z

PR_Github #65405 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-11T22:09:59Z

PR_Github #65406 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-11T22:10:03Z

PR_Github #65405 [ run ] completed with state ABORTED. Commit: 98bce4d

Link to invocation

tensorrt-cicd · 2026-08-12T00:31:27Z

PR_Github #65406 [ run ] completed with state SUCCESS. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #53163 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xrq-phys

LGTM

xrq-phys · 2026-08-18T07:20:45Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-18T07:26:14Z

PR_Github #67018 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-18T07:57:32Z

PR_Github #67018 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54564 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T05:12:31Z

/bot run --disable-fail-fast

ishovkun · 2026-08-19T05:19:16Z

/bot run --disable-fail-fast

ishovkun · 2026-08-19T05:28:12Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T05:34:14Z

PR_Github #67294 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T05:56:55Z

PR_Github #67294 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54816 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T06:01:05Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T06:07:24Z

PR_Github #67308 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T06:28:31Z

PR_Github #67308 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54828 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T06:30:35Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T06:36:54Z

PR_Github #67324 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

ishovkun · 2026-08-19T09:18:43Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T09:25:24Z

PR_Github #67385 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T09:51:14Z

PR_Github #67385 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54894 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T09:55:05Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T10:00:24Z

PR_Github #67397 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T10:22:34Z

PR_Github #67397 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54904 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T10:23:40Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T10:29:17Z

PR_Github #67408 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T10:56:23Z

PR_Github #67408 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54915 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T10:57:21Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T11:03:49Z

PR_Github #67411 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T11:28:57Z

PR_Github #67411 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54918 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T11:31:37Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T11:36:56Z

PR_Github #67415 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T11:59:24Z

PR_Github #67415 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54921 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T12:00:09Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T12:22:58Z

PR_Github #67425 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T12:45:35Z

PR_Github #67425 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54930 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T12:46:18Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T12:52:20Z

PR_Github #67434 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T13:13:58Z

PR_Github #67434 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54937 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T15:35:37Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T15:41:09Z

PR_Github #67481 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T16:07:50Z

PR_Github #67481 [ run ] completed with state FAILURE. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54979 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

ishovkun · 2026-08-19T16:16:43Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-08-19T16:23:46Z

PR_Github #67493 [ run ] triggered by Bot. Commit: 98bce4d Link to invocation

tensorrt-cicd · 2026-08-19T19:56:55Z

PR_Github #67493 [ run ] completed with state SUCCESS. Commit: 98bce4d
/LLM/main/L0_MergeRequest_PR pipeline #54990 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

ishovkun requested a review from a team as a code owner August 11, 2026 21:57

ishovkun requested review from yibinl-nvidia and zhenhuaw-me August 11, 2026 21:57

github-actions Bot assigned ishovkun Aug 11, 2026

github-actions Bot added the VisualGen label Aug 11, 2026

brnguyen2 approved these changes Aug 11, 2026

View reviewed changes

BowenFu approved these changes Aug 12, 2026

View reviewed changes

xrq-phys approved these changes Aug 18, 2026

View reviewed changes

xrq-phys reviewed Aug 18, 2026

View reviewed changes

Comment thread tensorrt_llm/_torch/visual_gen/models/cosmos3/negative_prompt.py

brnguyen2 added the ci: full pre-merge approved label Aug 19, 2026

yibinl-nvidia approved these changes Aug 19, 2026

View reviewed changes

chang-l merged commit 9c89503 into NVIDIA:main Aug 19, 2026
18 of 21 checks passed

Uh oh!

Conversation

ishovkun commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

ishovkun commented Aug 11, 2026

Uh oh!

ishovkun commented Aug 11, 2026

Uh oh!

tensorrt-cicd commented Aug 11, 2026

Uh oh!

tensorrt-cicd commented Aug 11, 2026

Uh oh!

tensorrt-cicd commented Aug 11, 2026

Uh oh!

tensorrt-cicd commented Aug 12, 2026

Uh oh!

xrq-phys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xrq-phys commented Aug 18, 2026

Uh oh!

tensorrt-cicd commented Aug 18, 2026

Uh oh!

tensorrt-cicd commented Aug 18, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

tensorrt-cicd commented Aug 19, 2026

Uh oh!

ishovkun commented Aug 11, 2026 •

edited

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading