Skip to content

[None][test] Remove UCX cases on qa side - #17389

Merged
fredricz-20070104 merged 2 commits into
NVIDIA:mainfrom
fredricz-20070104:feature/remove_ucx
Aug 7, 2026
Merged

[None][test] Remove UCX cases on qa side#17389
fredricz-20070104 merged 2 commits into
NVIDIA:mainfrom
fredricz-20070104:feature/remove_ucx

Conversation

@fredricz-20070104

@fredricz-20070104 fredricz-20070104 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed UCX disaggregated performance configurations for GB200 and GB300.
  • Removed matching UCX entries from QA performance lists.
  • Retained NIXL test coverage.
  • Changes have no API or production-code impact.
  • Verify that no external automation references the deleted UCX configurations.

QA Engineer Review

  • Removed UCX entries from:
    • tests/integration/test_lists/qa/llm_perf_disagg.yml
    • tests/integration/test_lists/qa/llm_perf_multinode.txt
  • Removed 14 UCX benchmark configuration files under tests/scripts/perf/disaggregated/.
  • No test functions changed.
  • NIXL scenarios remain in the QA lists.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Remove UCX cases on qa side

Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 32c6d0e0-e0d2-4bb7-ae72-4a3a94435393

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc76ef and ef7fd4a.

📒 Files selected for processing (16)
  • tests/integration/test_lists/qa/llm_perf_disagg.yml
  • tests/integration/test_lists/qa/llm_perf_multinode.txt
  • tests/scripts/perf/disaggregated/gb200_deepseek-r1-fp4_128k8k_con128_ctx1_pp8_gen1_dep16_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_deepseek-r1-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_deepseek-v32-fp4_32k4k_con2048_ctx1_dep4_gen1_dep32_eplb288_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_deepseek-v32-fp4_8k1k_con4096_ctx1_dep4_gen1_dep32_eplb256_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_glm-5-fp4_8k1k_con1024_ctx1_dep4_gen1_dep8_eplb256_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_gpt-oss-120b-fp4_8k1k_con1024_ctx1_tp1_gen1_tp4_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_qwen3-235b-fp4_8k1k_con1024_ctx1_tp1_gen1_dep8_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-r1-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-v32-fp4_32k4k_con2048_ctx1_dep4_gen1_dep32_eplb288_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-v32-fp4_8k1k_con4096_ctx1_dep4_gen1_dep32_eplb256_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_glm-5-fp4_8k1k_con1024_ctx1_dep2_gen1_dep8_eplb256_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-UCX.yaml
💤 Files with no reviewable changes (16)
  • tests/scripts/perf/disaggregated/gb300_deepseek-r1-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-v32-fp4_32k4k_con2048_ctx1_dep4_gen1_dep32_eplb288_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_deepseek-v32-fp4_32k4k_con2048_ctx1_dep4_gen1_dep32_eplb288_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_gpt-oss-120b-fp4_8k1k_con1024_ctx1_tp1_gen1_tp4_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_glm-5-fp4_8k1k_con1024_ctx1_dep2_gen1_dep8_eplb256_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_deepseek-v32-fp4_8k1k_con4096_ctx1_dep4_gen1_dep32_eplb256_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_deepseek-r1-fp4_128k8k_con128_ctx1_pp8_gen1_dep16_eplb0_mtp1_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_qwen3-235b-fp4_8k1k_con1024_ctx1_tp1_gen1_dep8_eplb0_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_deepseek-v32-fp4_8k1k_con4096_ctx1_dep4_gen1_dep32_eplb256_mtp0_ccb-UCX.yaml
  • tests/scripts/perf/disaggregated/gb200_glm-5-fp4_8k1k_con1024_ctx1_dep4_gen1_dep8_eplb256_mtp1_ccb-UCX.yaml
  • tests/integration/test_lists/qa/llm_perf_multinode.txt
  • tests/scripts/perf/disaggregated/gb200_deepseek-r1-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp1_ccb-UCX.yaml
  • tests/integration/test_lists/qa/llm_perf_disagg.yml

Walkthrough

The change removes selected GB200 and GB300 UCX disaggregated benchmark configurations. It updates timeout and multinode performance lists to retain or add NIXL scenarios.

Changes

UCX performance coverage removal

Layer / File(s) Summary
Remove UCX benchmark configurations
tests/scripts/perf/disaggregated/*-UCX.yaml
Selected GB200 and GB300 UCX benchmark configurations were deleted.
Update performance test coverage
tests/integration/test_lists/qa/llm_perf_disagg.yml, tests/integration/test_lists/qa/llm_perf_multinode.txt
GB200 and GB300 timeout and multinode lists remove selected UCX entries and retain or add NIXL scenarios.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change but omits the required Description, Test Coverage, and PR Checklist sections. Add the required sections with the motivation, affected tests or validation, and completed checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of UCX QA test cases and follows the repository title format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@fredricz-20070104

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "skip test as just modify some test configs, only run in qa side"

@fredricz-20070104
fredricz-20070104 enabled auto-merge (squash) August 7, 2026 01:24
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64442 [ skip ] triggered by Bot. Commit: a9c5a8d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64442 [ skip ] completed with state SUCCESS. Commit: a9c5a8d
Skipping testing for commit a9c5a8d

Link to invocation

@fredricz-20070104
fredricz-20070104 merged commit e447b6c into NVIDIA:main Aug 7, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants