[None][test] Handle MiniMax-M3 FP8 rounding variance - #17227
Merged
brb-nv merged 1 commit intoAug 4, 2026
Merged
Conversation
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
peihu-nv
requested review from
brnguyen2,
schetlur-nv,
xinhe-nv,
yiqingy0,
yuanjingx87 and
zongfeijing
August 3, 2026 21:56
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #63569 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #63569 [ run ] completed with state |
xinhe-nv
approved these changes
Aug 4, 2026
1 task
brb-nv
pushed a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
Aug 25, 2026
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
The MiniMax-M3 FP8 indexer and direct KV-insertion tests compared Q/K outputs byte-for-byte with the general fused QK-norm/RoPE reference. The specialized kernels use
powffor RoPE frequencies, while the optimized reference uses the mathematically equivalentexp2f/log2fformulation. A small number of values can consequently round to adjacent E4M3 values and fail byte equality despite satisfying the intended FP8 numerical contract.Compare only normalized/RoPE Q and K numerically using the tolerance already established by the horizontal-producer test. V conversion, cache destinations, guard pages, and CUDA Graph replay updates remain exact. Add the standalone indexer, direct KV-insertion, and active horizontal-producer tests to the B200 MiniMax-M3 pre-merge test list.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.