[None][perf] Extend packed MiniMax-M3 producer to mixed and decode batches - #16955
Merged
peihu-nv merged 1 commit intoJul 29, 2026
Conversation
Collaborator
Author
|
/bot run |
1 similar comment
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #62214 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #62218 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #62214 [ run ] completed with state |
Collaborator
|
PR_Github #62218 [ run ] completed with state |
peihu-nv
marked this pull request as ready for review
July 28, 2026 17:37
peihu-nv
requested review from
YihuiLu512,
lori-ren,
yechank-nvidia and
zongfeijing
July 28, 2026 17:37
ZhanruiSunCh
force-pushed
the
feat/m3_with_msa
branch
from
July 29, 2026 02:11
ee63e3f to
625aa0c
Compare
ZhanruiSunCh
requested review from
QiJune,
StanleySun639,
arysef,
chienchunhung,
jieli-matrix,
kris1025,
leslie-fang25,
lowsfer,
nvpohanh,
reasonsolo,
schetlur-nv,
tburt-nv,
xxi-nv and
yuanjingx87
and removed request for
a team
July 29, 2026 02:11
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
peihu-nv
force-pushed
the
peihengh/m3-pr16852-agg-horizontal-20260727
branch
from
July 29, 2026 04:21
42a1bed to
e0159c7
Compare
1 task
brb-nv
pushed a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
Aug 25, 2026
…tches (NVIDIA#16955) Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Prerequisite
Description
PR #16852 uses one packed MXFP8
[Q|K|V|index-Q|index-K]projection forMiniMax-M3, but restricts its horizontal norm/RoPE/cache-insertion producer to
pure prefill. Aggregate mixed and decode batches therefore split the packed
output and return to the separate main and index producer paths, repeating
intermediate materialization, normalization, RoPE, quantization, and cache
writes on generation steps.
This PR reuses the existing token-major horizontal producer for aggregate
mixed batches and CUDA-graph decode. Per-token positions and cache slots already
describe all three batch types, so the change removes the batch-type and
CUDA-graph restrictions while preserving the existing compile, shape, dtype,
MSA, FP8-cache, RoPE, and layout guards. The packed optimization remains opt-in
through
fuse_qkv_index_projection=Falseby default.An initial matched GB300 aggregate TP8/EP8 attention-DP A/B used exact 8K input,
1K output, concurrency 256, and 2,560 requests. Both variants completed every
request with identical input and output token counts:
This aggregate measurement predates #16923, which optimizes the downstream MSA
mixed-batch execution stage and is now part of the target branch. The two
changes operate on different pipeline stages. A matched GB300 disaggregated
TP8/EP8 GEN-only A/B on the current target branch showed no measurable decode
throughput gain, while median TPOT improved by 1.3%.
Test Coverage
cache destinations, and a padded negative cache slot.
through batch size 256 and completed 2,560/2,560 requests in both variants
with identical token counts.
successfully and showed flat decode throughput with a 1.3% median TPOT
improvement.
producer built and validated in [None][perf] Fuse MiniMax-M3 prefill projections #16852.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.