Skip to content

[https://nvbugs/6501376][fix] Test-only fix — drop the if hidden_size % 2 != 0: with pytest.raises(...)… #16844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QiJune merged 4 commits into from
Jul 27, 2026
Merged

[https://nvbugs/6501376][fix] Test-only fix — drop the if hidden_size % 2 != 0: with pytest.raises(...)… #16844

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77df102
[nvbugs/6501376][fix] Drop stale pytest.raises for uneven-TP row/colu…
HandongLi-01 Jul 24, 2026
736fc59
[nvbugs/6501376][fix] Remove uneven linear test waivers
QiJune Jul 25, 2026
3c09b66
[nvbugs/6501376][fix] Pass per-rank sizes to uneven-TP column linear …
lori-ren Jul 26, 2026
eb39108
[nvbugs/6501376][fix] Reject gather_output combined with override_tp_…
lori-ren Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/integration/test_lists/waives.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ full:B300/disaggregated/test_disaggregated.py::test_disaggregated_ctxpp2_genpp2[
full:B300/test_e2e.py::test_qwen_e2e_cpprunner_large_new_tokens[DeepSeek-R1-Distill-Qwen-1.5B-DeepSeek-R1-Distill-Qwen-1.5B] SKIP (https://nvbugs/6414760)
full:DGX_B200/accuracy/test_disaggregated_serving.py::TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True] SKIP (https://nvbugs/6501837)
full:DGX_B200/accuracy/test_llm_api_pytorch.py::TestDeepSeekV4ProDSpark::test_gsm8k_dep8_megamoe_deepgemm SKIP (https://nvbugs/6506920)
full:DGX_H100/unittest/_torch/multi_gpu/test_linear.py::test_column_linear[2-unbalanced] SKIP (https://nvbugs/6506918)
full:DGX_H200/accuracy/test_llm_api_pytorch.py::TestDeepSeekV32::test_fp8_blockscale[disable_skip_indexer] SKIP (https://nvbugs/6476233)
full:DGX_H200/accuracy/test_llm_api_pytorch.py::TestDeepSeekV32::test_fp8_blockscale[latency_default] SKIP (https://nvbugs/6476233)
full:GB200/accuracy/test_dwdp_disaggregated_serving.py::TestDwdpDeepSeekV3Lite::test_dwdp_accuracy SKIP (https://nvbugs/6276923)
Expand Down Expand Up @@ -352,7 +351,6 @@ unittest/_torch/modules/moe/test_moe_backend.py::test_moe_backend[act=Relu2-e60_
unittest/_torch/modules/moe/test_moe_module.py::test_configurable_moe_single_gpu -k "TRTLLM" SKIP (https://nvbugs/6464169)
unittest/_torch/modules/tests_lora_modules/test_nemotron_h_lora_sanity.py::TestNemotronHLoRA::test_lora_pp2_sanity SKIP (https://nvbugs/6428124)
unittest/_torch/multi_gpu/test_linear.py::test_row_linear[2-balanced] SKIP (https://nvbugs/6507113)
unittest/_torch/multi_gpu/test_linear.py::test_row_linear[2-unbalanced] SKIP (https://nvbugs/6501394)
unittest/_torch/multi_gpu/test_linear.py::test_row_linear_norm_fusion[2-hidden:16-seqlen:2] SKIP (https://nvbugs/6501404)
unittest/_torch/ray_orchestrator/multi_gpu/test_llm_update_weights_multi_gpu.py -m "part0" SKIP (https://nvbugs/6490036)
unittest/_torch/ray_orchestrator/multi_gpu/test_llm_update_weights_multi_gpu.py -m "part1" SKIP (https://nvbugs/6490036)
Expand Down
18 changes: 4 additions & 14 deletions tests/unittest/_torch/multi_gpu/test_linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,13 +286,8 @@ def test_column_linear(hidden_size, mpi_pool_executor):
run_single_rank,
*zip(*[(tensor_parallel_size, column_linear_forward, x, [l0_weight],
hidden_size, dtype)] * 2))
if hidden_size % 2 != 0:
with pytest.raises(AssertionError):
for r in results:
assert r is True
else:
for r in results:
assert r is True
for r in results:
assert r is True


@pytest.mark.skipif(torch.cuda.device_count() < 2,
Expand All @@ -311,13 +306,8 @@ def test_row_linear(hidden_size, mpi_pool_executor):
run_single_rank,
*zip(*[(tensor_parallel_size, row_linear_forward, x, [l0_weight],
hidden_size, dtype)] * 2))
if hidden_size % 2 != 0:
with pytest.raises(AssertionError):
for r in results:
assert r is True
else:
for r in results:
assert r is True
for r in results:
assert r is True


@pytest.mark.skipif(torch.cuda.device_count() < 2,
Expand Down
Loading