[TRTLLM-14388][refactor] BREAKING: Remove 2-model code and tests - #16380
[TRTLLM-14388][refactor] BREAKING: Remove 2-model code and tests#16380mikeiovine wants to merge 9 commits into
Conversation
|
/bot run --disable-fail-fast |
|
PR_Github #59235 [ run ] triggered by Bot. Commit: |
|
PR_Github #59235 [ run ] completed with state |
4764a86 to
97e26c8
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #59758 [ run ] triggered by Bot. Commit: |
97e26c8 to
dd496c8
Compare
4807177 to
cfe1571
Compare
|
/bot run --disable-fail-fast |
cfe1571 to
fb94cd2
Compare
|
/bot run |
|
/bot run --disable-fail-fast |
|
PR_Github #63808 [ run ] triggered by Bot. Commit: |
|
PR_Github #63809 [ run ] triggered by Bot. Commit: |
|
PR_Github #63808 [ run ] completed with state |
|
PR_Github #63809 [ run ] completed with state
|
Signed-off-by: Mike Iovine <miovine@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>
The 2-model removal deleted Eagle3SpecMetadata and every producer of request_accepted_path but left one use behind, which would raise NameError on any speculative decoding step. Also tighten the legacy ruff baseline to match the current tree. Signed-off-by: Mike Iovine <miovine@nvidia.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
eec6a59 to
46245ad
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #64076 [ run ] triggered by Bot. Commit: |
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #64089 [ run ] triggered by Bot. Commit: |
|
PR_Github #64076 [ run ] completed with state |
|
PR_Github #64089 [ run ] completed with state
|
Signed-off-by: Mike Iovine <miovine@nvidia.com>
|
/bot run --disable-fail-fast |
|
/bot cancel |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
I am going to split up this PR. There are more merge conflicts than I anticipated |
|
PR_Github #64362 [ ] completed with state |
Description
Remove 2-model code and related tests. We are past the deprecation period and all feature gaps have been closed.
Some 2-model code is left behind for a few niche things that can't use 1-model (ngram, user-provided).
Test Coverage
Existing tests.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
ModelDrafter,MTPDraftModelForCausalLM,Eagle3SpecMetadata, and related CUDA-graph and KV-cache branches.eagle3_one_model,mtp_eagle_one_model,is_draft_model, anddraft_model_engine.QA Engineer Review
test_draft_token_prepare_for_generationandtest_draft_token_tree_sampling.test_eagle3,test_eagle3_spec_decoding_stats,test_multi_eagle3,test_get_num_spec_layers_*,test_accepts_mtp_eagle,test_detect_hidden_states_capture_last_layer_for_mtp_eagle, andtest_autodeploy_eagle3_acceptance_rate.tests/integration/test_lists/test-db/,tests/integration/test_lists/qa/, andtests/integration/test_lists/waives.txtwhere applicable.l0_b200.yml.