[TRTLLM-13458][feat] Support Minimax M3 MXFP8 checkpoint - #15687
Conversation
📝 WalkthroughWalkthroughThe PR updates MiniMax M3 references, configs, docs, routing, and tests to add MXFP8 alongside BF16. It changes deployment examples, throughput settings, accuracy references, and adds an MXFP8 integration test case. ChangesMiniMax M3 MXFP8 support
Sequence Diagram(s)sequenceDiagram
participant ComponentA
participant ComponentB
ComponentA->>ComponentB: observable interaction
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/deployment-guide/deployment-guide-for-minimax-m3-on-trtllm.md`:
- Line 16: The intra-doc link in the deployment guide points to a non-existent
anchor, so update the Markdown link in the opening description to target a real
heading or add the missing section with a matching slug. Check the referenced
“Choosing the Parallelism Strategy” text and the document’s existing headings to
make sure the fragment matches exactly and the link resolves correctly.
- Line 127: The refreshed serve instructions are using the non-preferred
configuration path for `trtllm-serve`. Update the guidance in the deployment doc
to point users to `--config` instead of `--extra_llm_api_options` and
`$EXTRA_LLM_API_FILE`, and keep the rest of the setup language aligned with the
`trtllm-serve` flow. Make sure the section that discusses tuning YAML-based
settings and selecting the checkpoint directory still references the same serve
workflow, but with `--config` as the documented mechanism.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4d9884ea-2c7e-491c-98d1-edc3b12253d7
📒 Files selected for processing (9)
docs/source/_static/config_db.jsondocs/source/deployment-guide/deployment-guide-for-minimax-m3-on-trtllm.mdexamples/configs/curated/lookup.yamlexamples/configs/curated/minimax-m3-throughput.yamltensorrt_llm/_torch/modules/fused_moe/routing.pytests/integration/defs/accuracy/references/gsm8k.yamltests/integration/defs/accuracy/references/mmlu.yamltests/integration/defs/accuracy/test_llm_api_pytorch.pytests/integration/test_lists/qa/llm_function_core.txt
|
/bot run --disable-fail-fast |
|
PR_Github #56178 [ run ] triggered by Bot. Commit: |
|
PR_Github #56178 [ run ] completed with state
|
Signed-off-by: WeiHaocheng <20514172+WeiHaocheng@users.noreply.github.com>
Signed-off-by: WeiHaocheng <20514172+WeiHaocheng@users.noreply.github.com>
bca2804 to
ac4885f
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #56808 [ run ] triggered by Bot. Commit: |
|
PR_Github #56808 [ run ] completed with state
|
|
/bot run |
|
PR_Github #56951 [ run ] triggered by Bot. Commit: |
|
PR_Github #56951 [ run ] completed with state
|
|
/bot run |
|
PR_Github #56967 [ run ] triggered by Bot. Commit: |
|
PR_Github #56967 [ run ] completed with state
|
|
/bot run |
|
PR_Github #57015 [ run ] triggered by Bot. Commit: |
|
Retriggering as waive MR just merged: #15850 |
|
/bot run --disable-fail-fast |
|
PR_Github #57024 [ run ] triggered by Bot. Commit: |
|
PR_Github #57015 [ run ] completed with state |
|
PR_Github #57024 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #57038 [ run ] triggered by Bot. Commit: |
|
PR_Github #57038 [ run ] completed with state |
Signed-off-by: WeiHaocheng <20514172+WeiHaocheng@users.noreply.github.com>
Signed-off-by: WeiHaocheng <20514172+WeiHaocheng@users.noreply.github.com>
6 participants
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.