Skip to content

[https://nvbugs/6190759][fix] Promote the multi-node guard to a module-level pytest.mark.skipif so skipping ha #14533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tensorrt-cicd wants to merge 1 commit into from
Closed

[https://nvbugs/6190759][fix] Promote the multi-node guard to a module-level pytest.mark.skipif so skipping ha #14533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/unittest/llmapi/apps/_test_disagg_serving_multi_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@
NODE_LIST = expand_slurm_nodelist(os.environ.get("SLURM_NODELIST", ""))
SLURM_NTASKS_PER_NODE = int(os.environ.get("SLURM_NTASKS_PER_NODE", 1))

pytestmark = pytest.mark.threadleak(enabled=False)
pytestmark = [
pytest.mark.threadleak(enabled=False),
pytest.mark.skipif(len(NODE_LIST) != 2,
reason="This test is only expected to run with 2 nodes"),
]

# This test assumes that there are >2 nodes, we run ctx/disagg-server/client on the first node,
# and run gen the second node.
Expand Down Expand Up @@ -186,9 +190,6 @@ def client(disagg_server: RemoteDisaggOpenAIServer):

def test_completion(client: openai.OpenAI,
disagg_server: RemoteDisaggOpenAIServer, model_name: str):
if len(NODE_LIST) != 2:
pytest.skip("This test is only expected to run with 2 nodes")
return
if is_pytest_node():
print(f"running test_completion on rank {RANK} node rank {NODE_RANK}")
prompt = "What is the result of 1+1? Answer in one word: "
Expand Down
Loading