[https://nvbugs/6018046][fix] Drop max_batch_size 32→8 for throughput_pp4_mtp (matching throughput_bs8_mtp), l - #14201
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR adjusts the DeepSeekR1 NVFP4 multi-GPU test to handle multi-token prediction (MTP) scenarios more gracefully. The KV-cache memory fraction is now conditional based on parallelization and MTP settings, the batch size parameter is reduced for one configuration, and the test waiver is removed to allow the test to run. ChangesDeepSeekR1 NVFP4 KV-cache and test adjustment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
85da7bd to
6de877f
Compare
… bs8_mtp The throughput_pp4_mtp variant uses pp_size=4 with ep_size=1, which keeps all 256 experts on every rank rather than sharding them. Per-GPU weight footprint is therefore much higher than the EP-sharded throughput_mtp/throughput_tp8 variants, leaving little headroom on top of a 0.70 KV-cache fraction. Under the post-merge B300 load, the runtime cuBLAS / NCCL workspaces would intermittently hit allocator pressure and the router GEMM in DeepseekV3Gate faulted with CUBLAS_STATUS_EXECUTION_FAILED (followed by an asynchronous illegal-memory-access). The Repair Bot already showed the test passes deterministically on a fresh B300 node, so the fix is to bring this variant in line with the already-working throughput_bs8_mtp configuration: * drop max_batch_size from 32 -> 8 (same as throughput_bs8_mtp), shrinking activation / CUDA-graph / NCCL workspace memory * lower the KV cache fraction to 0.5 specifically for the pp_size>1 + ep_size=1 + mtp_nextn>0 path so prefill workspaces fit Removes the matching waiver entry. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
6de877f to
ac93618
Compare
|
NVBug 6018046 is closed as Bug - Fixed. The linked bug appears resolved elsewhere or for a reason that does not prove this PR is redundant. This PR should be judged on its own merits; repair-bot is not auto-closing it. |
|
Close this stale PR since the nvbug is closed. |
Summary
Test plan
Links
Summary by CodeRabbit
Note: This release contains internal testing improvements with no user-facing changes.