Skip to content

[None][refactor] Delegate MX checkpoint loading to ModelExpress #14151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhengluo-nv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[None][refactor] Delegate MX checkpoint loading to ModelExpress #14151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tensorrt_llm/_torch/models/checkpoints/auto_mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ def get(format: str, name: Optional[str] = None) -> "BaseWeightMapper":
try:
return MODEL_CLASS_MAPPER_MAPPING[f'{name}_{format}']()
except KeyError: # no mapper for this model architecture, resort to default
if format == "MX":
# MX uses HF on-disk checkpoint format for fallback, so
# an architecture-specific HF mapper is closer than the
# generic MX/HF default mapper.
if format == "modelexpress":
# ModelExpress uses HF on-disk checkpoint format for
# fallback, so an architecture-specific HF mapper is closer
# than the generic ModelExpress/HF default mapper.
try:
return MODEL_CLASS_MAPPER_MAPPING[f'{name}_HF']()
except KeyError:
Expand Down
2 changes: 1 addition & 1 deletion tensorrt_llm/_torch/models/checkpoints/hf/config_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from tensorrt_llm._torch.models.modeling_utils import register_config_loader


@register_config_loader("MX")

@zhengluo-nv zhengluo-nv May 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from MX -> modelexpress to keep consistent branding across all inference engines. In vLLM and SGLang we use modelexpress because MX may confuse customers with MXFP4/MXFP8 format.

@register_config_loader("modelexpress")
@register_config_loader("HF")
class HfConfigLoader(BaseConfigLoader):

Expand Down
2 changes: 1 addition & 1 deletion tensorrt_llm/_torch/models/checkpoints/hf/weight_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
from tensorrt_llm.mapping import Mapping


@register_checkpoint_weight_loader("MX")
@register_checkpoint_weight_loader("modelexpress")
@register_checkpoint_weight_loader("mistral")
@register_checkpoint_weight_loader("mistral_large_3")
@register_checkpoint_weight_loader("HF")
Expand Down
2 changes: 1 addition & 1 deletion tensorrt_llm/_torch/models/checkpoints/hf/weight_mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from ..base_weight_mapper import BaseWeightMapper


@register_mapper("MX")
@register_mapper("modelexpress")
@register_mapper("HF")
class HfWeightMapper(BaseWeightMapper):

Expand Down
Loading