Skip to content

[None][test] Waive 2 failed cases for main in QA CI #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xinhe-nv wants to merge 1 commit into from
Closed

[None][test] Waive 2 failed cases for main in QA CI #13304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/integration/test_lists/waives.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,3 +422,5 @@ accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16[mtp_nextn=2-
full:DGX_B200/examples/test_visual_gen.py::test_wan_t2v_example SKIP (https://nvbugs/6097980)
accuracy/test_disaggregated_serving.py::TestDeepSeekV32Exp::test_auto_dtype[False] SKIP (https://nvbugs/6098442)
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16[mtp_nextn=2-attention_dp=False-cuda_graph=False-overlap_scheduler=False-torch_compile=True-enable_chunked_prefill=False-v2_kv_cache=True] SKIP (https://nvbugs/6098790)
accuracy/test_llm_api_pytorch.py::TestQwen3_5_35B_A3B::test_bf16 SKIP (https://nvbugs/6069543)
accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_chunked_prefill[triton-auto] SKIP (https://nvbugs/6026676)
Comment on lines +425 to +426

@coderabbitai coderabbitai Bot Apr 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix formatting: replace em dash with space before SKIP.

Both new entries use an em dash (—) between the test nodeid and SKIP, which is inconsistent with all existing entries (lines 1–424) that use a single space. This formatting inconsistency could cause the waive matcher to fail to skip the intended tests.

As per coding guidelines, the waives file format is "<test-nodeid> SKIP (optional reason/link)" with a space separator. Based on learnings, the short nvbug URL format is correctly used.

📝 Proposed fix 
-accuracy/test_llm_api_pytorch.py::TestQwen3_5_35B_A3B::test_bf16 — SKIP (https://nvbugs/6069543)
-accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_chunked_prefill[triton-auto] — SKIP (https://nvbugs/6026676)
+accuracy/test_llm_api_pytorch.py::TestQwen3_5_35B_A3B::test_bf16 SKIP (https://nvbugs/6069543)
+accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_chunked_prefill[triton-auto] SKIP (https://nvbugs/6026676)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@tests/integration/test_lists/waives.txt` around lines 425 - 426, Replace the
em dash separator with a single space before "SKIP" for the two entries so they
match the file format "<test-nodeid> SKIP (reason)"; specifically update the
lines for accuracy/test_llm_api_pytorch.py::TestQwen3_5_35B_A3B::test_bf16 and
accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_chunked_prefill[triton-auto]
to use a space followed by "SKIP (https://nvbugs/...)" instead of an em dash.

Loading