Skip to content

[https://nvbugs/5875296][fix] Fix TritonMOE test for Qwen3_30B_A3B - #11495

Merged
dongfengy merged 2 commits into
NVIDIA:release/1.2from
dongfengy:user/dongfengy/5875296
Feb 16, 2026
Merged

[https://nvbugs/5875296][fix] Fix TritonMOE test for Qwen3_30B_A3B#11495
dongfengy merged 2 commits into
NVIDIA:release/1.2from
dongfengy:user/dongfengy/5875296

Conversation

@dongfengy

@dongfengy dongfengy commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

The test was newly enabled and never passed.
It was a wrong setup. TritonMOE kernels on Hopper require bf16 activation.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure with adjusted backend configurations for latency and accuracy measurements, focusing on specific backend combinations to streamline testing pipelines.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dongfengy
dongfengy requested a review from a team as a code owner February 13, 2026 02:52
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Test parameterization adjustments removing TRITON backend from several integration tests. Specifically, moe_backend options are narrowed to CUTLASS and TRTLLM in multiple test cases, and a FP8 TRITON latency test is replaced with a FP16 variant. These changes reduce test matrix combinations without altering test logic or public interfaces.

Changes

Cohort / File(s) Summary
Test Parameterization Updates
tests/integration/defs/accuracy/test_llm_api_pytorch.py
Removed TRITON from moe_backend parameter options across test_nvfp4, test_w4a8_mxfp4, test_w4a16_mxfp4, and related test cases. Narrowed moe_backend combinations to CUTLASS and TRTLLM only, reducing test runtime and overall test matrix size.
Test List Entry Replacement
tests/integration/test_lists/qa/llm_function_core.txt
Replaced FP8 TRITON latency test entry with FP16 variant: removed test_w4a8_mxfp4[fp8-latency-TRITON] and added test_w4a16_mxfp4[latency-TRITON], changing precision configuration for latency measurement on TRITON backend.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description provides the core issue (test misconfiguration requiring bf16 activation) but lacks detail on specific changes and test coverage as required by the template. Expand description to detail what specific test configurations were changed and why; explicitly list relevant test cases under Test Coverage section.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the issue (TritonMOE test fix for Qwen3_30B_A3B) and references the NVBugs ticket, directly matching the changeset which adjusts test parameterization.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into release/1.2

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35859 [ run ] triggered by Bot. Commit: f9f488b

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35859 [ run ] completed with state SUCCESS. Commit: f9f488b
/LLM/release-1.2/L0_MergeRequest_PR pipeline #359 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35885 [ run ] triggered by Bot. Commit: afc6e09

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35885 [ run ] completed with state SUCCESS. Commit: afc6e09
/LLM/release-1.2/L0_MergeRequest_PR pipeline #366 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy
dongfengy force-pushed the user/dongfengy/5875296 branch from afc6e09 to 0cdb4a3 Compare February 13, 2026 16:44
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35924 [ run ] triggered by Bot. Commit: 0cdb4a3

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35924 [ run ] completed with state SUCCESS. Commit: 0cdb4a3
/LLM/release-1.2/L0_MergeRequest_PR pipeline #369 completed with status: 'SUCCESS'

@dongfengy
dongfengy merged commit aa4c677 into NVIDIA:release/1.2 Feb 16, 2026
5 checks passed
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 18, 2026
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 18, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 19, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 19, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 19, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 20, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mk-nvidia pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 20, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 21, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 23, 2026
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 23, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 23, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
chzblych pushed a commit that referenced this pull request Feb 24, 2026
…11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
…VIDIA#11495)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants