Skip to content

[None][chore] Fix gpu memory requirement in stress test - #11404

Merged
xinhe-nv merged 1 commit into
NVIDIA:release/1.2from
dominicshanshan:user/shanshan/stress_test_memory_requirement_bug_fix
Feb 23, 2026
Merged

[None][chore] Fix gpu memory requirement in stress test#11404
xinhe-nv merged 1 commit into
NVIDIA:release/1.2from
dominicshanshan:user/shanshan/stress_test_memory_requirement_bug_fix

Conversation

@dominicshanshan

@dominicshanshan dominicshanshan commented Feb 10, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Release Notes

  • Tests
    • Updated stress test memory configurations to use explicit MiB units
    • Enhanced memory error messages to display requirements in both MiB and GB for improved clarity

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dominicshanshan
dominicshanshan requested a review from a team as a code owner February 10, 2026 03:05
@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Memory configuration values in the stress test were converted from gigabyte units to explicit mebibyte units throughout the file, with corresponding comments added to document the conversions. The control flow and test logic remain unchanged.

Changes

Cohort / File(s) Summary
Stress Test Memory Configuration
tests/integration/defs/stress_test/stress_test.py
Updated ModelConfig memory requirements from GB to explicit MiB values (12 GB → 12288 MiB, 96 GB → 98304 MiB, 256 GB → 262144 MiB, 168 GB → 172032 MiB). Added inline comments documenting MiB equivalents. Updated memory check error messages to reflect MiB units with both MiB and GB representations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty—only the template structure is present with no actual content filling the required sections (Description, Test Coverage, PR Checklist items unchecked). Add a Description section explaining what was changed and why, list the relevant test coverage, and review/check the PR Checklist items as appropriate.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Fix gpu memory requirement in stress test' directly and clearly describes the main change in the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
tests/integration/defs/stress_test/stress_test.py (2)

1-1: Copyright year is outdated.

The copyright header reads 2022-2024, but this file is being modified in 2026. As per coding guidelines, all TensorRT-LLM source files should contain a copyright header with the year of latest meaningful modification.

-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.

501-506: get_device_memory() is called three times — cache the result.

get_device_memory() shells out to nvidia-smi (or reads /proc/meminfo) on every call. It's invoked once on line 502 and twice more on line 505. Store the result in a local variable.

♻️ Proposed fix
     # get_device_memory() returns per-GPU memory in MiB
-    if get_device_memory() < config.memory_requirement:
+    device_memory = get_device_memory()
+    if device_memory < config.memory_requirement:
         pytest.skip(
             f"Not enough GPU memory. Required: {config.memory_requirement} MiB ({config.memory_requirement // 1024} GB), "
-            f"Available: {get_device_memory()} MiB ({get_device_memory() // 1024} GB)"
+            f"Available: {device_memory} MiB ({device_memory // 1024} GB)"
         )

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35427 [ run ] triggered by Bot. Commit: d0bbcbf

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35427 [ run ] completed with state SUCCESS. Commit: d0bbcbf
/LLM/release-1.2/L0_MergeRequest_PR pipeline #342 completed with status: 'SUCCESS'

@xinhe-nv
xinhe-nv force-pushed the user/shanshan/stress_test_memory_requirement_bug_fix branch from d0bbcbf to 58e81a7 Compare February 11, 2026 02:07
@xinhe-nv
xinhe-nv enabled auto-merge (squash) February 11, 2026 02:07
@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "A10-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35566 [ run ] triggered by Bot. Commit: 58e81a7

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35566 [ run ] completed with state SUCCESS. Commit: 58e81a7
/LLM/release-1.2/L0_MergeRequest_PR pipeline #344 (Partly Tested) completed with status: 'SUCCESS'

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35605 [ run ] triggered by Bot. Commit: 58e81a7

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35605 [ run ] completed with state SUCCESS. Commit: 58e81a7
/LLM/release-1.2/L0_MergeRequest_PR pipeline #346 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35638 [ run ] triggered by Bot. Commit: 58e81a7

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35638 [ run ] completed with state DISABLED
CI server is currently disabled for unplanned maintenance. Estimated completion time: 8 AM PST on 2/11.

@litaotju litaotju left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Simple test configuration update to use explicit MiB units and improve error messages

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35745 [ run ] triggered by Bot. Commit: 58e81a7

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35745 [ run ] completed with state SUCCESS. Commit: 58e81a7
/LLM/release-1.2/L0_MergeRequest_PR pipeline #349 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35762 [ run ] triggered by Bot. Commit: 58e81a7

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35762 [ run ] completed with state SUCCESS. Commit: 58e81a7
/LLM/release-1.2/L0_MergeRequest_PR pipeline #350 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dominicshanshan
dominicshanshan force-pushed the user/shanshan/stress_test_memory_requirement_bug_fix branch from 58e81a7 to 5825d29 Compare February 12, 2026 13:15
@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35786 [ run ] triggered by Bot. Commit: 5825d29

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35786 [ run ] completed with state SUCCESS. Commit: 5825d29
/LLM/release-1.2/L0_MergeRequest_PR pipeline #352 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35960 [ run ] triggered by Bot. Commit: 926b5b5

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35960 [ run ] completed with state SUCCESS. Commit: 926b5b5
/LLM/release-1.2/L0_MergeRequest_PR pipeline #372 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@dominicshanshan
dominicshanshan force-pushed the user/shanshan/stress_test_memory_requirement_bug_fix branch from 926b5b5 to a22c7b9 Compare February 14, 2026 08:42
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35968 [ run ] triggered by Bot. Commit: a22c7b9

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35969 [ run ] triggered by Bot. Commit: a22c7b9

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35969 [ run ] completed with state SUCCESS. Commit: a22c7b9
/LLM/release-1.2/L0_MergeRequest_PR pipeline #374 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36034 [ run ] triggered by Bot. Commit: a22c7b9

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36034 [ run ] completed with state SUCCESS. Commit: a22c7b9
/LLM/release-1.2/L0_MergeRequest_PR pipeline #375 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@dominicshanshan
dominicshanshan force-pushed the user/shanshan/stress_test_memory_requirement_bug_fix branch from a22c7b9 to af86c1c Compare February 21, 2026 04:50
@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36372 [ run ] triggered by Bot. Commit: af86c1c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36372 [ run ] completed with state SUCCESS. Commit: af86c1c
/LLM/release-1.2/L0_MergeRequest_PR pipeline #379 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dominicshanshan
dominicshanshan force-pushed the user/shanshan/stress_test_memory_requirement_bug_fix branch 2 times, most recently from 10aba9e to f7741a6 Compare February 23, 2026 05:32
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
@dominicshanshan
dominicshanshan force-pushed the user/shanshan/stress_test_memory_requirement_bug_fix branch from f7741a6 to 405c272 Compare February 23, 2026 08:38
@dominicshanshan

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36481 [ run ] triggered by Bot. Commit: 405c272 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36481 [ run ] completed with state SUCCESS. Commit: 405c272
/LLM/release-1.2/L0_MergeRequest_PR pipeline #382 completed with status: 'SUCCESS'

Link to invocation

@xinhe-nv
xinhe-nv merged commit 4f6acbb into NVIDIA:release/1.2 Feb 23, 2026
5 checks passed
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 23, 2026
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 23, 2026
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Feb 23, 2026
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
chzblych pushed a commit that referenced this pull request Feb 24, 2026
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
dominicshanshan added a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
thorjohnsen pushed a commit to thorjohnsen/TensorRT-LLM that referenced this pull request Apr 21, 2026
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <miovine@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants