Skip to content

[https://nvbugs/5821433][fix] complete WAR for popen in QA env #11214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazydemo merged 2 commits into from
Feb 5, 2026
Merged

[https://nvbugs/5821433][fix] complete WAR for popen in QA env #11214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3775eaa
fix fileno error
crazydemo Feb 3, 2026
36b29b8
Merge branch 'release/1.2' into fix_fileno
LarryXFly Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/integration/defs/disaggregated/test_auto_scaling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import os
import shutil
import subprocess
import sys
import tempfile
import traceback
import uuid
Expand Down Expand Up @@ -187,14 +186,13 @@ def run_disagg_server(disagg_cluster_config, work_dir, port=0, save_log=False):
cmds = ["trtllm-serve", "disaggregated", "-c", disagg_server_config_path]
log_file = None
log_path = None
stdout = None
stderr = None
if save_log:
log_path = os.path.join(work_dir, "disagg_server.log")
log_file = open(log_path, "w+")
stdout = log_file
stderr = log_file
else:
stdout = sys.stdout
stderr = sys.stderr
p = subprocess.Popen(cmds, stdout=stdout, stderr=stderr)
return ProcessWrapper(p, log_file=log_file, log_path=log_path, port=port)

Expand Down