Skip to content

Conversation

@Linda-Stadter
Copy link
Collaborator

@Linda-Stadter Linda-Stadter commented Jan 27, 2026

Summary by CodeRabbit

  • Refactor
    • Removed Python language bindings for core library components including batch manager, executor, runtime, and related modules. Python API access to these components is no longer available.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Linda-Stadter
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33729 [ run ] triggered by Bot. Commit: 0061b3b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33729 [ run ] completed with state SUCCESS. Commit: 0061b3b
/LLM/main/L0_MergeRequest_PR pipeline #26014 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@Linda-Stadter
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33743 [ run ] triggered by Bot. Commit: 0061b3b

@Linda-Stadter Linda-Stadter changed the title [None][chore] Removing pybind folder [None][chore] Removing cpp/tensorrt_llm/pybind Jan 27, 2026
@Linda-Stadter Linda-Stadter self-assigned this Jan 27, 2026
@Linda-Stadter Linda-Stadter marked this pull request as ready for review January 27, 2026 16:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

This PR completely removes the pybind11-based Python bindings infrastructure for TensorRT LLM, including the CMakeLists.txt build configuration and binding implementations across all modules (batch_manager, executor, runtime, testing, thop, userbuffers, process_group, and common utilities).

Changes

Cohort / File(s) Summary
CMake Build Configuration
cpp/tensorrt_llm/pybind/CMakeLists.txt
Removes entire CMake build configuration that assembled the Python bindings module, including pybind11 module definition, source enumeration, include paths, link libraries (torch, Python, CUDA, th_common, pg_utils), and build properties.
Batch Manager Bindings
cpp/tensorrt_llm/pybind/batch_manager/{algorithms, bindings, buffers, cacheTransceiver, kvCacheConnector, kvCacheManager, kvCacheManagerV2Utils, llmRequest}.*
Removes Python bindings for batch manager components: scheduling algorithms (CapacityScheduler, MicroBatchScheduler), request/buffer management (GenericLlmRequest, DecoderInputBuffers, DecoderOutputBuffers), KV cache operations (KVCacheManager, CacheTransceiver, KvCacheConnector), and associated utility functions.
Executor Module Bindings
cpp/tensorrt_llm/pybind/executor/{bindings, executor, executorConfig, request}.*
Removes Python bindings for executor functionality: core Executor class with constructor/lifecycle methods, configuration structures (ExecutorConfig, DynamicBatchConfig, SchedulerConfig, KvCacheConfig, etc.), and request/response types (Request, Response, Result, with extensive nested configurations).
Runtime Module Bindings
cpp/tensorrt_llm/pybind/runtime/{bindings, hostfunc, moeBindings}.*
Removes Python bindings for runtime components: decoder/generation infrastructure (ITensor, GptDecoderBatched, DecodingInput/Output), CUDA utilities (CudaEvent, CudaStream, HostFunc), MOE load balancing (MoeLoadBalancer), and virtual memory management.
Testing & Torch Operation Bindings
cpp/tensorrt_llm/pybind/{testing/modelSpecBinding, thop/bindings}.*
Removes Python bindings for test infrastructure (ModelSpec with configuration options) and torch operations (attention kernel, Helix workspace computation, MoE A2A metadata).
User Buffers & Process Group Bindings
cpp/tensorrt_llm/pybind/{userbuffers, process_group}/bindings.*
Removes Python bindings for user buffer management (UBBuffer, allocation/deallocation) and process group initialization.
Common Binding Utilities
cpp/tensorrt_llm/pybind/common/{bindTypes, customCasters, tllmExceptions}.*
Removes shared binding infrastructure: container binding helpers (bindList/bindSet templates), type casters for Pybind11 (OptionalRef, filesystem paths, CUDA streams, Tensors/ITensors), and exception translation (RequestSpecificException).
Main Binding Entry Point
cpp/tensorrt_llm/pybind/bindings.cpp
Removes the central pybind11 module initialization that wired all submodules (batch_manager, executor, runtime, testing, thop, userbuffers, process_group), exposed enums/classes (DataType, ModelConfig, WorldConfig, SamplingConfig, MpiComm, etc.), and registered binding initializers.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • kaiyux
  • poweiw
  • QiJune
  • pcastonguay
  • venkywonka
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive PR description is vague and lacks specific details about why this change is needed and what the impact is. Expand the description to explain the rationale for removing pybind bindings, expected impact on users, migration path for dependent code, and reference the continuation from PR #10550 more clearly.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly identifies the main change: removing cpp/tensorrt_llm/pybind folder and its pybind11 bindings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33743 [ run ] completed with state SUCCESS. Commit: 0061b3b
/LLM/main/L0_MergeRequest_PR pipeline #26026 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinMarciniszyn MartinMarciniszyn merged commit 29647d9 into NVIDIA:main Jan 28, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants