Skip to content

Conversation

@pranavm-nvidia
Copy link
Collaborator

…erties of outputs

See the docstring in frontend/constraints/base.py for more details.

…erties of outputs

See the docstring in `frontend/constraints/base.py` for more details.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive constraints system for validating inputs and guaranteeing properties of outputs in the tripy library. The system provides a declarative way to specify validation rules and output guarantees using composable constraint objects.

  • Adds a base constraints framework with pattern matching capabilities
  • Implements logical constraints (And, Equal, NotEqual, OneOf, Not) with operator overloading
  • Provides fetchers for accessing input parameters, return values, and data types

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tripy/nvtripy/frontend/constraints/init.py Exports all constraint classes and core interfaces
tripy/nvtripy/frontend/constraints/base.py Defines base Constraints class with pattern matching functionality
tripy/nvtripy/frontend/constraints/fetcher.py Implements value fetchers for inputs, returns, and data types
tripy/nvtripy/frontend/constraints/logic.py Provides logical constraint operations with operator overloading
tripy/tests/frontend/constraints/init.py Empty test package initialization file
tripy/tests/frontend/constraints/test_base.py Tests for pattern matching and constraint tree operations
tripy/tests/frontend/constraints/test_fetcher.py Tests for value fetcher functionality and data type extraction
tripy/tests/frontend/constraints/test_logic.py Tests for logical constraint operations and combinations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants