Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .agents/skills/nemoclaw-maintainer-day/scripts/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,15 @@ export const RISKY_PATTERNS: RegExp[] = [
/inference/i,
];

const DOCUMENTATION_PATTERNS: RegExp[] = [/^docs\//, /^fern\//];

export const TEST_PATTERNS: RegExp[] = [/\.test\.[jt]sx?$/, /\.spec\.[jt]sx?$/, /^test\//];

export function isRiskyFile(path: string): boolean {
return RISKY_PATTERNS.some((re) => re.test(path));
return (
!DOCUMENTATION_PATTERNS.some((pattern) => pattern.test(path)) &&
RISKY_PATTERNS.some((pattern) => pattern.test(path))
);
}

export function isTestFile(path: string): boolean {
Expand Down
31 changes: 31 additions & 0 deletions test/skills/check-gates-compliance.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,37 @@ import { describe, expect, it } from "vitest";
import { REQUIRED_CHECK_NAMES, runComparatorGate, runGate } from "./check-gates-test-fixtures.ts";

describe("maintainer merge-gate contributor compliance", () => {
it("excludes public docs but keeps inference source behind the risky-code test gate (#9934)", () => {
const docsOutput = JSON.parse(
runGate({
body: "Signed-off-by: Example User <user@example.com>",
verified: true,
files: [
{ path: "docs/inference/set-up-vllm.mdx", status: "modified" },
{ path: "docs/policy/network-access.mdx", status: "modified" },
{ path: "fern/assets/inference-policy.svg", status: "modified" },
],
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}).stdout,
);
const sourceOutput = JSON.parse(
runGate({
body: "Signed-off-by: Example User <user@example.com>",
verified: true,
files: [{ path: "src/lib/inference/provider.ts", status: "modified" }],
}).stdout,
);

expect(docsOutput.gates.riskyCodeTested).toMatchObject({
pass: true,
details: "No risky files changed",
});
expect(sourceOutput.gates.riskyCodeTested).toMatchObject({
pass: false,
riskyFiles: ["src/lib/inference/provider.ts"],
hasTests: false,
});
});

it("classifies the merge-gate checker as risky code with direct test coverage", () => {
const output = JSON.parse(
runGate({
Expand Down
Loading