Skip to content

fix(security): restore retained remediation and CI gates - #9936

Merged
cv merged 2 commits into
mainfrom
codex/restore-main-gates
Aug 22, 2026
Merged

fix(security): restore retained remediation and CI gates#9936
cv merged 2 commits into
mainfrom
codex/restore-main-gates

Conversation

@apurvvkumaria

@apurvvkumaria apurvvkumaria commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Current main leaves two retained OpenClaw remediation paths on affected tar@7.5.19 and contains an MCP concurrency fixture that can miss the lifecycle-lock race. This change selects the reviewed tar@7.5.21, updates the matching security evidence, and corrects the concurrency fixture without changing product behavior.

Changes

  • Select the reviewed tar@7.5.21 registry identity for the retained openclaw@2026.6.10 and E2E-only openclaw@2026.3.11 remediation paths.
  • Update the retained dependency review, metadata integrities, archive fixtures, and security-image expectation for the corrected package identity.
  • Initialize the MCP sandbox registry before the competing processes start so the concurrency test begins at the lifecycle lock.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: independent repository review is pending; the nine-category agent review found no findings.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit: Not applicable
  • Station profile/scenario: Not applicable
  • Result: Not applicable
  • Supporting evidence: Not applicable

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run passed 114 tests in seven files; one image-dependent test was skipped.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — local macOS run: 36,658 passed, 369 failed, and 445 skipped. Failures were in unchanged platform, Python 3.9, package-cache, and timing paths. No failure is accepted; required GitHub checks must pass.
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Apurv Kumaria akumaria@nvidia.com

Summary by CodeRabbit

  • Security

    • Updated the OpenClaw dependency remediation to use tar 7.5.21, including refreshed integrity and package metadata.
    • Updated license inventory records and security review revalidation information.
  • Bug Fixes

    • Improved consistency when adding MCP processes concurrently, reducing the risk of credential projection races and related crashes.
  • Tests

    • Updated dependency, archive, metadata, and end-to-end checks to validate the refreshed security remediation.

Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
@apurvvkumaria apurvvkumaria self-assigned this Aug 21, 2026
@apurvvkumaria apurvvkumaria added bug-fix PR fixes a bug or regression security area: security Security controls, permissions, secrets, or hardening area: ci CI workflows, checks, release automation, or GitHub Actions integration: openclaw OpenClaw integration behavior v0.0.114 labels Aug 21, 2026
@github-code-quality

github-code-quality Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 73de26b in the codex/restore-main-g... branch remains at 96%, unchanged from commit f9f8da2 in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit 73de26b in the codex/restore-main-g... branch remains at 83%, unchanged from commit f9f8da2 in the main branch.

Show a line coverage summary of the most impacted files.
File main f9f8da2 codex/restore-main-g... 73de26b +/-
src/lib/inferen...apter-common.ts 91% 74% -17%
src/lib/inferen...pter-forward.ts 79% 73% -6%
src/lib/onboard...uild-context.ts 86% 86% 0%
src/lib/inferen...apter-server.ts 65% 65% 0%
src/lib/messagi...els/metadata.ts 100% 100% 0%
src/lib/sandbox...rce-identity.ts 81% 81% 0%
src/lib/tunnel/services.ts 81% 81% 0%
src/lib/inferen...er-lifecycle.ts 62% 63% +1%

Updated August 21, 2026 22:26 UTC

@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@apurvvkumaria

Copy link
Copy Markdown
Collaborator Author

CI Blocker

Repository automation integrated current main and resolved the formatting conflict without changing the validated tree. GitHub then marked the required workflows as awaiting additional NVIDIA runner validation, and the copy-PR notice says a pull request vetter must approve them before they can run.

The focused local validation passed 114 tests in seven files, with one image-dependent test skipped. No workflow rerun, administrator bypass, or synthetic branch update has been used. Required checks cannot complete until a human vetter approves the current revision.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 04ef89c8-8c84-4eea-a750-bc0ca667fbaf

📥 Commits

Reviewing files that changed from the base of the PR and between f9f8da2 and 73de26b.

📒 Files selected for processing (7)
  • internal/security-reviews/openclaw-2026.6.10-dependency-review.md
  • scripts/lib/openclaw-npm-remediation.mts
  • test/mcp-add-crash-consistency.test.ts
  • test/openclaw-2026-6-npm-remediation.test.ts
  • test/openclaw-dependency-review.test.ts
  • test/openclaw-npm-remediation.test.ts
  • test/openclaw-security-revision-container-e2e.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Changes

OpenClaw tar remediation

Layer / File(s) Summary
Tar remediation data and metadata
scripts/lib/openclaw-npm-remediation.mts, internal/security-reviews/...
The remediation flow and security review records now use tar@7.5.21 with updated integrity, URL, metadata, and license values.
Tar remediation validation
test/openclaw-*-remediation.test.ts, test/openclaw-dependency-review.test.ts, test/openclaw-security-revision-container-e2e.test.ts
Tests now assert tar@7.5.21 and its updated archive metadata. Existing parameterized coverage remains unchanged.

MCP sandbox initialization

Layer / File(s) Summary
Pre-spawn sandbox registry setup
test/mcp-add-crash-consistency.test.ts
The concurrent credential-projection test initializes the sandbox registry before spawning add processes. Child processes skip duplicate initialization.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to 73de2

This change updates retained security remediation identities and a concurrency fixture, but the applicable broad validation gate is not passing: the recorded run has 369 failures with no acceptance documented. Merge should wait for the required checks to pass or for explicit maintainer acceptance.

Possibly related PRs

  • NVIDIA/NemoClaw#7360: Both changes update the OpenClaw npm remediation flow and its legacy tar tests.

Suggested labels: area: e2e

Suggested reviewers: ericksoa, cv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (1 skipped: 1 unsupported.) Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main security remediation and CI gate restoration described in the pull request objectives.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/restore-main-gates

Comment @coderabbitai help to get the list of available commands.

@senthilr-nv senthilr-nv added chore Build, CI, dependency, or tooling maintenance and removed bug-fix PR fixes a bug or regression labels Aug 21, 2026

@cv cv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact commit 73de26b. DCO, GitHub verification, required CI, the tar 7.5.21 supply-chain identity, retained remediation scope, security tests, and review threads pass.

@cv
cv merged commit e38db20 into main Aug 22, 2026
85 checks passed
@cv
cv deleted the codex/restore-main-gates branch August 22, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: security Security controls, permissions, secrets, or hardening chore Build, CI, dependency, or tooling maintenance integration: openclaw OpenClaw integration behavior security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants