docs(policy): list the teams preset in the Open tier table - #9504
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe Open tier policy table now lists the experimental ChangesNetwork policies documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation correction makes the Open tier’s Microsoft Teams egress preset visible without changing executable behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cv
added
chore
prekshivyas
left a comment
prekshivyas
left a comment
There was a problem hiding this comment.
Approved at exact head 4afcff3. Verified the policy source matches the shipped Open tier, generated all agent variants, and ran the full documentation validation successfully.
The Open row of the Policy Tiers table omitted `teams`. The `open` tier in nemoclaw-blueprint/policies/tiers.yaml has applied that preset since commit 17d0331, and the same page names that file as the store for tier definitions. An operator who selected Open from this table was not told that the tier opens Microsoft Teams egress by default. Commit a5768a2 corrected the same row the same way when it was missing `wechat`. This change repeats that correction for `teams` and keeps the experimental tag that docs/reference/platform-support.mdx records for the Microsoft Teams channel. Signed-off-by: Udaya Tejas <udayatejas2004@gmail.com>
4afcff3 to
0473cf7
Compare
PR Review Advisor — InformationalAdvisor assessment: Informational / low confidence Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
rsliter
left a comment
rsliter
left a comment
There was a problem hiding this comment.
Security Review: PASS
Commit under review: 0473cf7071dd221b8f16813a3d4ca7ef7df1bbf8
Base SHA: b2d1ce52a716444b083f6e3b8ed8bace1cba3240
The one-cell documentation correction matches nemoclaw-blueprint/policies/tiers.yaml: the Open tier already includes the teams preset between whatsapp and jira. Marking Teams experimental is consistent with the current platform-support documentation. The change discloses existing egress rather than enabling new egress or changing policy behavior.
Nine-category result:
- Input validation: PASS.
- Authentication and authorization: PASS.
- Secrets and sensitive data: PASS.
- Command and code injection: PASS.
- Path and filesystem safety: PASS.
- Network security: PASS.
- Cryptography and integrity: PASS.
- Dependency and supply-chain risk: PASS.
- Denial of service and failure handling: PASS.
The exact documentation receipt is current. Fern preview and docs-only checks passed. The PR description should check “Sensitive paths changed” and cite this review because the changed page documents policy egress.
Cross-issue sweep progress:
- Step 1: Extract fingerprint
- Step 2: Search candidate issues
- Step 3: Classify each candidate
- Step 4: Apply reverse-link boost
- Step 5: Filter
- Step 6: Render report
No adjacent fixes or contradictions were found above the medium-confidence floor.
6 participants
Summary
The Policy Tiers table in
docs/reference/network-policies.mdxdid not list theteamspreset in its Openrow, while the
opentier innemoclaw-blueprint/policies/tiers.yamlhas applied that preset since commit17d03317b(#5585). An operator who read this table before selecting Open was not told that the tier opensMicrosoft Teams egress by default. The Open row now names
teamsin the position it occupies intiers.yaml, with the experimental tag thatdocs/reference/platform-support.mdxrecords for the channel.Related Issue
Fixes #9503
This repeats a correction the project already accepted. Issue #3688 reported the identical drift for
wechat, and PR #4276 (commita5768a244) corrected the same row the same way. PR #5585 addedteamstothe
opentier and stated that it would "Leave user-facing documentation to a follow-up docs-owner change";that follow-up did not reach this page.
Changes
docs/reference/network-policies.mdx: add`teams` (experimental)to the Open row of the PolicyTiers table, between
whatsappandjira, matching the preset order innemoclaw-blueprint/policies/tiers.yaml.One existing table row changed. Net line delta is ±0 (1 insertion, 1 deletion, one file). No new
abstraction, configuration, fallback, migration, or compatibility path.
Checked and unchanged: the Restricted, Balanced, and Personal rows already match
tiers.yaml, soteamsis the table's only omission.
Not changed, and offered here instead: the
<AgentOnly variant="openclaw">note earlier on the same pagesays "The baseline policy does not include messaging endpoints for Telegram, Discord, Slack, WeChat, or
WhatsApp." That sentence omits Microsoft Teams and also Google Chat. Google Chat is not a tier preset, so
that sentence belongs to a different premise than this tier-table drift, and adding only Teams would leave
a new partial list. Say the word and I will extend that note in this PR or a separate one.
Type of Change
Quality Gates
executable behavior.
npm run docsis the validation for this page. If you want a guard against the nextrecurrence, the natural home is the existing tier-loader test surface for
src/lib/policy/tiers.ts: onecase that reads
resolveTierPresets("open")and asserts each preset name appears in the Open row ofdocs/reference/network-policies.mdx. That adds lines, so I left it out of this ±0 change and will add itin this PR if you prefer it here.
Documentation Writer Review
docs-updatedVerification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailable —npm run validate:prpassed after refreshingorigin/mainand rebasing onto the currentmainnpm run docsexits 0npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only) — 0 errors. The two reported warnings arethe unauthenticated Fern redirects check and the site accent-color contrast ratio; both appear identically
on an unmodified checkout of this page.
Signed-off-by: Udaya Tejas udayatejas2004@gmail.com
Summary by CodeRabbit
teamspreset in the Open policy tier.