fix(e2e): detect credential values in sandbox scans

nemoclaw/src/security/secret-scanner.ts

@@ -21,16 +21,49 @@ interface SecretPattern {
   regex: RegExp;
 }
 
+/** Provider token formats shared by the in-process and sandbox scanners. */
+export const HIGH_CONFIDENCE_PREFIXED_TOKEN_SPECS = [
+  {
+    name: "NVIDIA API key",
+    prefixes: ["nvapi-"],
+    payloadCharacterClass: "A-Za-z0-9_-",
+    minimumPayloadLength: 20,
+  },
+  {
+    name: "GitHub token",
+    prefixes: ["ghp_", "gho_", "ghu_", "ghs_", "ghr_", "github_pat_"],
+    payloadCharacterClass: "A-Za-z0-9",
+    minimumPayloadLength: 36,
+  },
+  {
+    name: "npm token",
+    prefixes: ["npm_"],
+    payloadCharacterClass: "A-Za-z0-9",
+    minimumPayloadLength: 36,
+  },
+] as const;
+
+/** POSIX ERE for high-confidence provider tokens in sandbox shell scans. */
+export const HIGH_CONFIDENCE_PREFIXED_TOKEN_ERE = `(${HIGH_CONFIDENCE_PREFIXED_TOKEN_SPECS.flatMap(
+  ({ prefixes, payloadCharacterClass, minimumPayloadLength }) =>
+    prefixes.map(
+      (prefix) => `${prefix}[${payloadCharacterClass}]{${minimumPayloadLength},}`,
+    ),
+).join("|")})`;
+
 const SECRET_PATTERNS: SecretPattern[] = [
-  // NVIDIA
-  { name: "NVIDIA API key", regex: /\bnvapi-[A-Za-z0-9_-]{20,}\b/ },
+  ...HIGH_CONFIDENCE_PREFIXED_TOKEN_SPECS.map(
+    ({ name, prefixes, payloadCharacterClass, minimumPayloadLength }) => ({
+      name,
+      regex: new RegExp(
+        `\\b(?:${prefixes.join("|")})[${payloadCharacterClass}]{${minimumPayloadLength},}\\b`,
+      ),
+    }),
+  ),
 
   // OpenAI — exclude sk-ant- (Anthropic) to avoid double-matching
   { name: "OpenAI API key", regex: /\bsk-(?!ant-)[A-Za-z0-9_-]{20,}\b/ },
 
-  // GitHub
-  { name: "GitHub token", regex: /\b(ghp|gho|ghu|ghs|ghr|github_pat)_[A-Za-z0-9]{36,}\b/ },
-
   // AWS
   { name: "AWS access key", regex: /\bAKIA[0-9A-Z]{16}\b/ },
   {
@@ -48,9 +81,6 @@ const SECRET_PATTERNS: SecretPattern[] = [
       /(?<=(?:discord|bot|DISCORD_TOKEN|BOT_TOKEN|token)\s*[=:]\s*["']?)[A-Za-z0-9]{24}\.[A-Za-z0-9_-]{6}\.[A-Za-z0-9_-]{27,}/,
   },
 
-  // npm
-  { name: "npm token", regex: /\bnpm_[A-Za-z0-9]{36,}\b/ },
-
   // Private keys (PEM)
   {
     name: "Private key",

test/e2e/live/cloud-inference.test.ts

@@ -32,6 +32,7 @@ import {
   parseCloudChatResponse,
   type PreContractExternalProviderFailure,
 } from "./cloud-inference-provider-skip.ts";
+import { HIGH_CONFIDENCE_PREFIXED_TOKEN_ERE } from "../../../nemoclaw/src/security/secret-scanner.ts";
 
 const REPO_SKILL_VALIDATOR = path.join(
   REPO_ROOT,
@@ -305,7 +306,7 @@ async function expectSandboxCredentialBoundary(
   const secretScanCommand = [
     "for dir in /sandbox/.openclaw /sandbox/.nemoclaw; do",
     '  [ -d "$dir" ] || continue',
-    `  matches=$(grep -rIlE 'nvapi-|ghp_|npm_' "$dir")`,
+    `  matches=$(grep -rIlE '${HIGH_CONFIDENCE_PREFIXED_TOKEN_ERE}' "$dir")`,
     "  scan_status=$?",
     '  case "$scan_status" in',
     `    0) filtered=$(printf '%s\\n' "$matches" | grep -Ev '/policies/|/plugin-runtime-deps/|/extensions/[^/]+/(dist|node_modules)/')`,
@@ -319,7 +320,7 @@ async function expectSandboxCredentialBoundary(
     "            write_status=$?",
     '            case "$write_status" in 0) ;; *) exit "$write_status" ;; esac',
     "            while IFS= read -r file; do",
-    `              matching_lines=$(grep -IE 'nvapi-|ghp_|npm_' "$file")`,
+    `              matching_lines=$(grep -IE '${HIGH_CONFIDENCE_PREFIXED_TOKEN_ERE}' "$file")`,
     "              match_status=$?",
     '              case "$match_status" in',
     `                0) printf '%s' "$matching_lines" | grep -qv 'STRIPPED'`,

test/e2e/support/cloud-inference-credential-pattern.test.ts

@@ -0,0 +1,42 @@
+// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+import { describe, expect, it } from "vitest";
+
+import { HIGH_CONFIDENCE_PREFIXED_TOKEN_ERE } from "../../../nemoclaw/src/security/secret-scanner.ts";
+
+const credentialPattern = new RegExp(HIGH_CONFIDENCE_PREFIXED_TOKEN_ERE, "u");
+
+describe("cloud inference credential scan", () => {
+  it.each([
+    "/sandbox/.openclaw/extensions/example/node_modules/thread-stream/test/ts/transpile.sh",
+    "/sandbox/.openclaw/extensions/example/node_modules/jwks-rsa/package.json",
+    "package-lock entry for npm_config_cache metadata",
+  ])("accepts dependency text without a credential value: %s", (value) => {
+    expect(value).not.toMatch(credentialPattern);
+  });
+
+  it.each([
+    `NVIDIA_INFERENCE_API_KEY=nvapi-${"a".repeat(30)}`,
+    `GITHUB_TOKEN=ghp_${"b".repeat(36)}`,
+    `NPM_TOKEN=npm_${"c".repeat(36)}`,
+  ])("detects a credential-shaped value", (value) => {
+    expect(value).toMatch(credentialPattern);
+  });
+
+  it.each([
+    ["nvapi-", 20],
+    ["ghp_", 36],
+    ["npm_", 36],
+  ])("enforces the minimum payload for %s", (prefix, minimumPayloadLength) => {
+    expect(`${prefix}${"a".repeat(minimumPayloadLength - 1)}`).not.toMatch(credentialPattern);
+    expect(`${prefix}${"a".repeat(minimumPayloadLength)}`).toMatch(credentialPattern);
+  });
+
+  it.each(["gho_", "ghu_", "ghs_", "ghr_", "github_pat_"])(
+    "detects a supported GitHub token prefix: %s",
+    (prefix) => {
+      expect(`${prefix}${"a".repeat(36)}`).toMatch(credentialPattern);
+    },
+  );
+});