Repository navigation
refactor(messaging): retire WhatsApp session path compatibility #9249
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,16 +85,13 @@ export type WhatsappProbeInput = { | |
| presetOnGateway: boolean | null; | ||
| // Whether the whatsapp channel is recorded in the registry messaging plan. | ||
| channelEnabledInRegistry: boolean; | ||
| // Hermes dashboard pairing and gateway startup share one canonical session | ||
| // path. This probe records only whether its credential file exists. | ||
| sessionLocations?: WhatsappSessionLocations; | ||
| }; | ||
|
|
||
| export type WhatsappSessionLocations = { | ||
| gatewaySessionCreds: boolean | null; | ||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -132,12 +129,6 @@ function isParseableTimestamp(value: string | null): value is string { | |
| return value !== null && Number.isFinite(Date.parse(value)); | ||
| } | ||
|
|
||
| function pairingSignal(input: WhatsappProbeInput): DiagnosticSignal { | ||
| if (!input.probeReachable) { | ||
| return { | ||
|
|
@@ -155,15 +146,12 @@ function pairingSignal(input: WhatsappProbeInput): DiagnosticSignal { | |
| }; | ||
| } | ||
| if (input.paired === false) { | ||
| if (input.agent === "hermes") { | ||
| return { | ||
| label: "Pairing / session", | ||
| severity: "warn", | ||
| detail: "Hermes gateway session path has no WhatsApp credentials", | ||
| hint: "run `hermes whatsapp` inside the sandbox to display a QR code", | ||
|
Collaborator
There was a problem hiding this comment. This command does not write the canonical durable path required by the probe above. In the pinned Hermes image, #8229 patches dashboard pairing only and deliberately leaves the CLI path unchanged, so this hint can leave status unpaired and the session non-durable after rebuild. Point to dashboard pairing, or add tested canonical CLI support across restart, status, and rebuild. |
||
| }; | ||
| } | ||
| const loginHint = | ||
|
|
@@ -184,98 +172,31 @@ function pairingSignal(input: WhatsappProbeInput): DiagnosticSignal { | |
| }; | ||
| } | ||
|
|
||
| function sessionLocationSignal(input: WhatsappProbeInput): DiagnosticSignal | null { | ||
| const locations = input.sessionLocations; | ||
| if (!locations) return null; | ||
| const gateway = locations.gatewaySessionCreds; | ||
| if (gateway === true) { | ||
| return { | ||
| label: "Session location", | ||
| severity: "ok", | ||
| detail: "Hermes gateway session path contains WhatsApp credentials", | ||
| }; | ||
| } | ||
| if (gateway === false) { | ||
| return { | ||
| label: "Session location", | ||
| severity: "info", | ||
| detail: "the Hermes gateway session path has no WhatsApp credentials", | ||
| }; | ||
| } | ||
| return { | ||
| label: "Session location", | ||
| severity: "info", | ||
| detail: "the Hermes gateway session path could not be inspected", | ||
| }; | ||
| } | ||
|
|
||
| function websocketSignal(input: WhatsappProbeInput): DiagnosticSignal { | ||
| if (input.heartbeatParseError) { | ||
| return { | ||
|
|
@@ -519,13 +440,6 @@ function buildHints(verdict: WhatsappVerdict, input: WhatsappProbeInput): string | |
| ); | ||
| break; | ||
| case "unpaired": | ||
| hints.push( | ||
| input.agent === "hermes" | ||
| ? "Run `hermes whatsapp` inside the sandbox and scan the QR with your phone." | ||
|
|
@@ -556,12 +470,10 @@ function buildHints(verdict: WhatsappVerdict, input: WhatsappProbeInput): string | |
|
|
||
| export function evaluateWhatsappDiagnostics(input: WhatsappProbeInput): WhatsappDiagnosticReport { | ||
| const sessionSignal = sessionLocationSignal(input); | ||
| const signals: DiagnosticSignal[] = [ | ||
| configCoverageSignal(input), | ||
| pairingSignal(input), | ||
| ...(sessionSignal ? [sessionSignal] : []), | ||
| bridgeProcessSignal(input), | ||
| websocketSignal(input), | ||
| inboundSignal(input), | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.