Skip to content

fix(test): remove the duplicate WSL spy from the connect harness #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dreamstick9 wants to merge 1 commit into from
Closed

fix(test): remove the duplicate WSL spy from the connect harness #9019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions test/support/connect-flow-test-harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { createRequire } from "node:module";
import { type MockInstance, vi } from "vitest";
import type { ManagedGatewayControlCompletion } from "../../src/lib/actions/sandbox/gateway-restart";
import type { SecretBoundaryRefusalReason } from "../../src/lib/actions/sandbox/hermes-secret-boundary-recovery";
import type { WslDetectionOptions } from "../../src/lib/platform";
import type { ConfigObject } from "../../src/lib/security/credential-filter";
import type { SandboxEntry } from "../../src/lib/state/registry";

Expand Down Expand Up @@ -275,15 +274,6 @@ export function createConnectHarness(options: ConnectHarnessOptions = {}): Conne
const probeOllamaAuthProxyHealthSpy = vi
.spyOn(ollamaProxy, "probeOllamaAuthProxyHealth")
.mockReturnValue({ ok: true });
const realIsWsl = platform.isWsl as (opts?: WslDetectionOptions) => boolean;
// Pin the platform gate for every isWsl consumer the harness loads: isWsl
// answers false off Linux before it reads WSL_DISTRO_NAME, so a case that
// stubs that variable cannot reach the WSL route on a macOS contributor
// machine. With the gate pinned, the stubbed environment decides, on every
// host, and a caller's own options still win over the pin (#8868).
vi.spyOn(platform, "isWsl").mockImplementation((...args: unknown[]) =>
realIsWsl({ platform: "linux", ...((args[0] as WslDetectionOptions | undefined) ?? {}) }),
);
const primaryRegistryEntry: SandboxEntry = {
name: "alpha",
agent: options.agentName ?? "openclaw",
Expand Down
Loading