Skip to content

fix(sandbox): install dos2unix in the Deep Agents Code base image #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 3 commits into from
Aug 10, 2026
Merged

fix(sandbox): install dos2unix in the Deep Agents Code base image #8701

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
992b56a
fix(sandbox): install dos2unix in the Deep Agents Code base image
Dongni-Yang Aug 10, 2026
c34844e
test(sandbox): scope the dos2unix pin assertion to what it checks
Dongni-Yang Aug 10, 2026
0a7f0d9
test(sandbox): assert dos2unix from the executed apt layer
Dongni-Yang Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions agents/langchain-deepagents-code/Dockerfile.base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
util-linux=2.41-5 \
procps=2:4.0.4-9 \
e2fsprogs=1.47.2-3+b11 \
"dos2unix=7.5.2-1*" \
openssh-sftp-server=1:10.0p1-7+deb13u4 \
ripgrep=14.1.1-1+b4 \
&& if [ -n "${NEMOCLAW_CORPORATE_CA_B64:-}" ]; then \
Expand Down
8 changes: 8 additions & 0 deletions test/sandbox-base-runtime-tools.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ describe("sandbox base runtime tools", () => {
expect(source).not.toMatch(/\bgosu\b/u);
});

it.each(
MANAGED_BASE_DOCKERFILES,
)("%s installs dos2unix under a version prefix pin that resolves on arm64 (#8691)", (dockerfile) => {
const source = fs.readFileSync(dockerfile, "utf-8");

expect(source).toContain('"dos2unix=7.5.2-1*"');
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

it("installs the required process, filesystem, and SFTP tools", () => {
const { calls, result } = runBaseAptLayer("nemoclaw-base-apt-");

Expand Down
Loading