docs: add a troubleshooting entry for the contributor setup heap error - #8689
Conversation
📝 WalkthroughWalkthroughAdded troubleshooting guidance for source-checkout setup failures caused by Node.js heap exhaustion on 8 GB hosts. The guidance sets a 5120 MB old-space limit and instructs contributors to rerun setup and subsequent commands. ChangesNode.js heap guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None 1 warning · 0 suggestionsWarningsWarnings do not block.
|
cv
left a comment
There was a problem hiding this comment.
This feels like a very specific troubleshooting issue. Can you put it in docs/reference/troubleshooting.mdx?
|
Moved it to Two notes:
|
|
Maintainer readiness update The requested relocation to Two blockers remain:
No approval, bypass, or merge was attempted. The PR remains open pending normal reviewer-state and advisor-automation recovery. |
The latest PR commit moves the guidance to docs/reference/troubleshooting.mdx as requested.
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Security and documentation review for the latest PR commit is complete. Security categories:
Documentation writer result: Change size: +17/-0 in one documentation file. No security or documentation blocker was found. Human approval and every required GitHub check remain required before merge. |
prekshivyas
left a comment
There was a problem hiding this comment.
Reviewed latest PR commit 389854c0b; no substantive documentation finding.
The troubleshooting entry matches issue #8688's reproduced source-checkout failure and verified NODE_OPTIONS=--max-old-space-size=5120 workaround, scopes the guidance away from installed releases, and records that the variable must remain set for later heavy Node commands. The requested move into the troubleshooting page is complete.
No approval because base aaaf5c150 is behind current main and the exact-commit required check set is no longer current.
prekshivyas
left a comment
There was a problem hiding this comment.
Reviewed the current head and found no documentation correctness or style issue. I am withholding approval because this branch does not contain current main; refresh the branch and rerun the required checks so approval can bind to the integrated exact head.
Summary
./scripts/dev-setup.shstops at the CLI type-check step on a host with 8 GB of RAM becausetsc -p tsconfig.cli.jsonexceeds the default Node.js old-space limit of about 2.2 GB. The failure surfaces as a V8 abort and a native stack trace, and no page named the cause or the remedy. This PR adds a troubleshooting entry that names the limit, the failing step, and theNODE_OPTIONSremedy.Related Issue
Reported in #8688.
This PR implements option 1 of the three directions listed in that issue. It does not close the issue because the maintainers may prefer option 2, which sets the limit in the type-check scripts, or option 3, which detects the failure in
dev-setup.shand the doctor.Changes
Contributor Setup Fails with a JavaScript Heap Out-of-Memory Errorto the Installation section ofdocs/reference/troubleshooting.mdx.NODE_OPTIONSvalue and the command to run setup again.This PR adds no abstraction, configuration, fallback, migration, or compatibility path. It changes no source file and no workflow.
Review History
The first revision put this guidance in the
CONTRIBUTING.mdprerequisites. @cv asked for it indocs/reference/troubleshooting.mdxinstead, soCONTRIBUTING.mdis byte-identical tomainand the entry lives on the troubleshooting page next to the other Installation entries. A later commit changed the new heading to title case to follow the heading rule indocs/CONTRIBUTING.md.Type of Change
Quality Gates
docs/reference/troubleshooting.mdx. It changes no source file, script, workflow, command, or default.Documentation Writer Review
docs-updateddocs/reference/troubleshooting.mdxat the latest PR commit againstWRITING.md,docs/CONTRIBUTING.md, current implementation, and all three generated guide variants. The reviewer confirmed the entry's placement, title case, source-checkout scope, numeric claims, andNODE_OPTIONSguidance.npm run docspassed with 0 errors and the same 2 warnings asmain; the complete hook suite andgit diff --checkalso passed.Codex DesktopVerification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablemarkdownlint-cli2,gitleaks,commitlint, the complete hook suite, and the pre-push TypeScript checks.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Notes on the unchecked verification items:
CONTRIBUTING.mdstates that a documentation-only change does not need the full test suite, sonpm testandnpm run checkdo not apply.npm run docs: The current build reports 0 errors and 2 warnings. Both warnings are present onmainand this PR changes one page underdocs/reference/.Signed-off-by: Vishnu Rajeev 19866703+VishnuR23@users.noreply.github.com
Summary by CodeRabbit