fix(sandbox): select gosu binary by target architecture - #861
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Dockerfile's Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Around line 29-36: The Dockerfile adds an arm64 case for gosu (arch="$(dpkg
--print-architecture)" and the case branch setting gosu_asset/gosu_sha256 for
arm64) but CI never builds an arm64 image; update the CI to exercise the arm64
path by adding an explicit arm64 build step (use docker buildx with QEMU
emulation or add an arm64 runner) that builds the image with --platform
linux/arm64 so the arm64 branch (the arm64 case and corresponding checksum) is
validated during PR builds.
* fix(sandbox): select gosu binary by target architecture * ci: add arm64 sandbox image builds --------- Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com>
* fix(sandbox): select gosu binary by target architecture * ci: add arm64 sandbox image builds --------- Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com> (cherry picked from commit 289a4b7) Signed-off-by: Vidul Ayakulangara Panickan <apvidul@gmail.com>
* fix(sandbox): select gosu binary by target architecture * ci: add arm64 sandbox image builds --------- Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com>
* fix(sandbox): select gosu binary by target architecture * ci: add arm64 sandbox image builds --------- Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com>
Summary
The sandbox Dockerfile currently hardcodes the
gosu-amd64release asset.That works on x86_64, but it can break arm64 sandbox builds with
Exec format errorwhen the image validatesgosu --version.This change selects the matching
gosubinary from the container architecture reported bydpkg --print-architecture, while keeping the pinned 1.19 release and SHA256 verification.Related Issue
Fixes #850
Changes
Type of Change
Testing
npx prek run --all-filespasses (or equivalentlymake check).npm testpasses.make docsbuilds without warnings. (for doc-only changes)Checklist
General
Code Changes
npx prek run --all-filesauto-fixes formatting (ormake formatfor targeted runs).Doc Changes
update-docsagent skill to draft changes while complying with the style guide. For example, prompt your agent with "/update-docscatch up the docs for the new changes I made in this PR."Summary by CodeRabbit