Skip to content

fix(e2e): record risk-signal evidence only for manual PR runs #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prekshivyas merged 4 commits into from
Aug 7, 2026
Merged

fix(e2e): record risk-signal evidence only for manual PR runs #8518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c63596f
fix(e2e): keep main pushes outside PR risk signals
prekshivyas Aug 7, 2026
e3fed18
Merge origin/main into agent/fix-main-risk-signal-activation
prekshivyas Aug 7, 2026
25e7fa8
test(e2e): reject main-push PR risk metadata
prekshivyas Aug 7, 2026
c1ad5d3
merge(main): refresh risk-signal activation fix
prekshivyas Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,7 +1970,7 @@ jobs:
E2E_JOB: "1"
E2E_TARGET_ID: "managed-image-multiarch-startup"
RELEASE_E2E_ACTIVATION_PATH: ci/protected-managed-image-multiarch-activation-v1.json
NEMOCLAW_E2E_EXPECTED_SHA: ${{ inputs.checkout_sha || github.sha }}
NEMOCLAW_E2E_EXPECTED_SHA: ${{ inputs.checkout_sha }}
NEMOCLAW_E2E_SHARD: ${{ matrix.shard }}
NEMOCLAW_PROTECTED_MANAGED_IMAGE_BASE_SHA: ${{ inputs.base_sha || github.event.before || github.sha }}
NEMOCLAW_PROTECTED_MANAGED_IMAGE_BUILD_CACHE: ${{ github.workspace }}/.protected-managed-image-build-cache/${{ matrix.shard }}
Expand Down Expand Up @@ -2389,7 +2389,7 @@ jobs:
E2E_ARTIFACT_DIR: ${{ github.workspace }}/e2e-artifacts/live/llama-cpp-dgx-spark-qualification
E2E_JOB: "1"
E2E_TARGET_ID: "llama-cpp-dgx-spark-qualification"
NEMOCLAW_E2E_EXPECTED_SHA: ${{ inputs.checkout_sha || github.sha }}
NEMOCLAW_E2E_EXPECTED_SHA: ${{ inputs.checkout_sha }}
NEMOCLAW_E2E_SHARD: linux-arm64-gpu-dgx-spark-gb10
NEMOCLAW_LLAMA_CPP_QUALIFICATION_BASE_SHA: ${{ inputs.base_sha || github.event.before || github.sha }}
NEMOCLAW_LLAMA_CPP_QUALIFICATION_CANDIDATE_ROOT: ${{ github.workspace }}/.candidate-llama-cpp
Expand Down
10 changes: 10 additions & 0 deletions test/e2e/support/llama-cpp-dgx-spark-qualification-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ describe("llama.cpp DGX Spark qualification workflow boundary (#8260)", () => {
expect(validateLlamaCppDgxSparkQualificationWorkflow(workflow())).toEqual([]);
});

it("does not record manual PR risk signals on main pushes", () => {
const value = workflow();
const jobEnv = job(value, "llama-cpp-dgx-spark-qualification").env as Record<string, unknown>;
jobEnv.NEMOCLAW_E2E_EXPECTED_SHA = "${{ inputs.checkout_sha || github.sha }}";

expect(validateLlamaCppDgxSparkQualificationWorkflow(value)).toContain(
"llama-cpp-dgx-spark-qualification env must bind NEMOCLAW_E2E_EXPECTED_SHA to ${{ inputs.checkout_sha }}",
);
});

it("rejects bypassing the declarative protected-runner plan", () => {
const value = workflow();
job(value, "llama-cpp-dgx-spark-qualification")["runs-on"] = "self-hosted";
Expand Down
10 changes: 10 additions & 0 deletions test/e2e/support/managed-image-protected-runtime-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ describe("protected managed-image runtime workflow boundary", () => {
expect(validateManagedImageProtectedRuntimeWorkflow(value)).toEqual([]);
});

it("does not record manual PR risk signals on main pushes", () => {
const value = workflow();
const jobEnv = multiarchJob(value).env as Record<string, unknown>;
jobEnv.NEMOCLAW_E2E_EXPECTED_SHA = "${{ inputs.checkout_sha || github.sha }}";

expect(validateManagedImageMultiarchWorkflow(value)).toContain(
"managed-image-multiarch-startup env must bind NEMOCLAW_E2E_EXPECTED_SHA to ${{ inputs.checkout_sha }}",
);
});

it("ships the exact activation contract consumed by the trusted lane (#7744)", () => {
const activation = JSON.parse(
fs.readFileSync(
Expand Down
2 changes: 1 addition & 1 deletion tools/e2e/llama-cpp-dgx-spark-qualification-workflow-boundary.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export function validateLlamaCppDgxSparkQualificationWorkflow(workflow: RecordVa
E2E_JOB: "1",
E2E_TARGET_ID: LLAMA_CPP_DGX_SPARK_QUALIFICATION_JOB_ID,
RELEASE_E2E_ACTIVATION_PATH: LLAMA_CPP_DGX_SPARK_QUALIFICATION_ACTIVATION_PATH,
NEMOCLAW_E2E_EXPECTED_SHA: "${{ inputs.checkout_sha || github.sha }}",
NEMOCLAW_E2E_EXPECTED_SHA: "${{ inputs.checkout_sha }}",
NEMOCLAW_LLAMA_CPP_QUALIFICATION_BASE_SHA:
"${{ inputs.base_sha || github.event.before || github.sha }}",
NEMOCLAW_LLAMA_CPP_QUALIFICATION_PLAN:
Expand Down
2 changes: 1 addition & 1 deletion tools/e2e/managed-image-multiarch-workflow-boundary.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export function validateManagedImageMultiarchWorkflow(workflow: WorkflowRecord):
"${{ github.workspace }}/e2e-artifacts/live/managed-image-multiarch-startup/${{ matrix.shard }}",
E2E_JOB: "1",
E2E_TARGET_ID: JOB_ID,
NEMOCLAW_E2E_EXPECTED_SHA: "${{ inputs.checkout_sha || github.sha }}",
NEMOCLAW_E2E_EXPECTED_SHA: "${{ inputs.checkout_sha }}",
NEMOCLAW_E2E_SHARD: "${{ matrix.shard }}",
NEMOCLAW_PROTECTED_MANAGED_IMAGE_BASE_SHA:
"${{ inputs.base_sha || github.event.before || github.sha }}",
Expand Down
Loading