Skip to content

fix: fall back to non-root mode when gosu is blocked by no-new-privileges #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericksoa merged 5 commits into from
Mar 25, 2026
+35 −1
Merged

fix: fall back to non-root mode when gosu is blocked by no-new-privileges #846

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c44d79d
fix: fall back to non-root mode when gosu is blocked by no-new-privil…
ericksoa Mar 25, 2026
2b20205
fix: guard all gosu calls behind root check
ericksoa Mar 25, 2026
fc7f154
chore: apply shfmt with -ci flag
ericksoa Mar 25, 2026
2317f9d
fix: use array for run_prefix to satisfy shellcheck SC2086
ericksoa Mar 25, 2026
0c6dced
fix(security): set HOME and warn on config integrity failure in non-r…
ericksoa Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion scripts/nemoclaw-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ PYTOKEN
start_auto_pair() {
# Run auto-pair as sandbox user (it talks to the gateway via CLI)
# SECURITY: Pass resolved openclaw path to prevent PATH hijacking
OPENCLAW_BIN="$OPENCLAW" nohup gosu sandbox python3 - <<'PYAUTOPAIR' >>/tmp/auto-pair.log 2>&1 &
# When running as non-root, skip gosu (we're already the sandbox user)
local run_prefix=()
if [ "$(id -u)" -eq 0 ]; then
run_prefix=(gosu sandbox)
fi
OPENCLAW_BIN="$OPENCLAW" nohup "${run_prefix[@]}" python3 - <<'PYAUTOPAIR' >>/tmp/auto-pair.log 2>&1 &
import json
import os
import subprocess
Expand Down Expand Up @@ -170,6 +175,35 @@ PYAUTOPAIR
echo 'Setting up NemoClaw...'
[ -f .env ] && chmod 600 .env

# ── Non-root fallback ──────────────────────────────────────────
# OpenShell runs containers with --security-opt=no-new-privileges, which
# blocks gosu's setuid syscall. When we're not root, skip privilege
# separation and run everything as the current user (sandbox).
# Gateway process isolation is not available in this mode.
if [ "$(id -u)" -ne 0 ]; then
echo "[gateway] Running as non-root (uid=$(id -u)) — privilege separation disabled"
export HOME=/sandbox
if ! verify_config_integrity; then
echo "[SECURITY WARNING] Config integrity check failed — proceeding anyway (non-root mode)"
fi
write_auth_profile
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if [ ${#NEMOCLAW_CMD[@]} -gt 0 ]; then
exec "${NEMOCLAW_CMD[@]}"
fi

# Start gateway in background, auto-pair, then wait
"$OPENCLAW" gateway run &
GATEWAY_PID=$!
echo "[gateway] openclaw gateway launched (pid $GATEWAY_PID)"
start_auto_pair
Comment thread
coderabbitai[bot] marked this conversation as resolved.
print_dashboard_urls
wait "$GATEWAY_PID"
exit $?
fi

# ── Root path (full privilege separation via gosu) ─────────────

# Verify config integrity before starting anything
verify_config_integrity

Expand Down
Loading