fix(inference): admit remediable Spark storage

[prekshivyas]

Summary

Managed serving selection now accepts the exact Docker storage conflict that NemoClaw's public lifecycle can remediate. The readiness report remains incompatible and host.docker.storage_compatible remains absent; selection admits it only when host.docker.storage_remediation_available is present and no other blocker exists.

Related Issue

Refs #8246
Parent epic: #8379

Changes

• Recognize the canonical, blocking host.docker.storage_incompatible finding as remediable only with the exact storage capability states produced by host readiness.
• Allow a host.docker.storage_compatible lifecycle requirement to use the documented remediation alternative without changing the public readiness report.
• Continue to reject missing remediation, additional blocking findings, fatal findings, malformed references, or any other incompatible readiness result.
• Add focused resolver coverage for successful admission and both fail-closed cases.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: docs/reference/system-readiness.mdx already specifies that lifecycle admission accepts either native storage compatibility or the remediation capability while preserving incompatible probe status and rejecting every other blocker.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: Existing docs/reference/system-readiness.mdx already documents the implemented storage remediation admission contract. The committed diff and 33 focused resolver tests passed review with no findings.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit: Not applicable.
• Station profile/scenario: Not applicable.
• Result: Not applicable.
• Supporting evidence: Not applicable.

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed
• Targeted behavior tests pass — src/lib/inference/serving/resolver.test.ts: 33/33 passed.
• Applicable broad gates passed — npm run typecheck:cli and npm run checks:repository passed.
• Read-only physical Spark probe reproduced the exact admitted shape: incompatible/exit 2, storage-compatible absent, remediation-available present, and the sole blocker host.docker.storage_incompatible.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Prekshi Vyas prekshiv@nvidia.com

Summary by CodeRabbit

• Bug Fixes
  • Improved readiness validation for environments with an incompatible Docker storage configuration when automatic remediation is available.
  • Ensured host-local selection is allowed only when storage remediation is supported and no other blocking issues remain.
• Tests
  • Added coverage for successful remediation, unsupported remediation, and additional blocking readiness findings.

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 53b67c4 in the agent/8246-storage-a... branch remains at 96%, unchanged from commit db31c28 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 53b67c4 in the agent/8246-storage-a... branch remains at 82%, unchanged from commit db31c28 in the main branch.

Show a code coverage summary of the most impacted files.

File	main db31c28	agent/8246-storage-a... 53b67c4	+/-
src/lib/inferen...ing/resolver.ts	89%	89%	0%
src/lib/sandbox...rce-identity.ts	87%	87%	0%
src/lib/inferen...er-discovery.ts	87%	88%	+1%

---

_{Updated August 05, 2026 22:20 UTC}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fc3cbd3a-b4ee-432a-b85c-06cc75dcd418

📥 Commits

Reviewing files that changed from the base of the PR and between 616b932 and 53b67c4.

📒 Files selected for processing (1)

• src/lib/inference/serving/resolver.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/lib/inference/serving/resolver.test.ts

---

📝 Walkthrough

Walkthrough

The resolver recognizes one remediable Docker storage incompatibility during readiness and capability validation. Tests cover accepted host-local selection and rejection when extra findings or remediation capability are missing.

Changes

Storage readiness resolution

Layer / File(s)	Summary
Remediable storage validation src/lib/inference/serving/resolver.ts	The resolver identifies the specific storage finding, allows it during readiness validation, and matches the compatible-storage requirement when remediation is available.
Remediation selection tests src/lib/inference/serving/resolver.test.ts	Tests cover successful explicit host-local selection, additional blocking or fatal findings, and unavailable remediation capability.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• NVIDIA/NemoClaw#8249: Adds host-local vLLM readiness logic extended by this change.
• NVIDIA/NemoClaw#8391: Modifies serving-readiness validation in the same resolver areas.

Suggested labels: area: inference, platform: dgx-spark

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: admitting remediable Spark storage during inference serving selection.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/8246-storage-admission

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized terminology decisions differ; normalized E2E selections match; severity counts match.

Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate.

1 semantic terminology decision

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• established — remediation at src/lib/inference/serving/resolver.test.ts:198: Keep `remediation`; it matches the controlled-word definition and the existing repository usage.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: inference-routing, network-policy

1 optional E2E recommendation

• vllm-docker-storage

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

[apurvvkumaria]

Approve — reviewed current head 53b67c4 with focus on the storage-remediation admission boundary, readiness integrity, rejection of additional blocking/fatal findings, compatibility, and tests. No blocking defect found; required checks and selected E2E are green.