Skip to content

fix: detect sandbox context in status command #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WuKongAI-CMU wants to merge 1 commit into from
Closed

fix: detect sandbox context in status command #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemoclaw/dist/commands/status.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions nemoclaw/dist/commands/status.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nemoclaw/dist/commands/status.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions nemoclaw/src/commands/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,22 @@
// SPDX-License-Identifier: Apache-2.0

import { exec } from "node:child_process";
import { existsSync } from "node:fs";
import { promisify } from "node:util";
import type { PluginLogger, NemoClawConfig } from "../index.js";
import { loadState } from "../blueprint/state.js";

const execAsync = promisify(exec);

/**
* Detect whether we are running inside an OpenShell sandbox.
* Inside the sandbox the filesystem is restricted to /sandbox and /tmp,
* and the openshell CLI cannot query its own container status.
*/
function isInsideSandbox(): boolean {
return existsSync("/sandbox") || process.env.OPENSHELL_SANDBOX === "1";
}

export interface StatusOptions {
json: boolean;
logger: PluginLogger;
Expand Down Expand Up @@ -96,6 +106,13 @@ interface SandboxStatusResponse {
}

async function getSandboxStatus(sandboxName: string): Promise<SandboxStatus> {
// When running inside the sandbox, openshell cannot query its own
// container. The fact that this code is executing proves the sandbox
// is running, so report that directly.
if (isInsideSandbox()) {
return { name: sandboxName, running: true, uptime: null };
}

try {
const { stdout } = await execAsync(`openshell sandbox status ${sandboxName} --json`, {
timeout: 5000,
Expand Down