docs: enforce guide variant publication scope - #7842
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
📝 WalkthroughWalkthroughThis PR adds explicit agent-variant scope metadata across documentation, derives publication membership from navigation, validates declarations during synchronization, updates shared guide routes and content, and adds tests for scope mismatches and published gateway lifecycle routes. ChangesAgent-variant documentation scope
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DocsIndex as docs/index.yml
participant SyncScript as sync-agent-variant-docs.mts
participant PublishedDocs as generated agent-variant docs
participant RouteTests as check-docs-published-routes.test.ts
DocsIndex->>SyncScript: provide variant navigation membership
SyncScript->>SyncScript: validate frontmatter scope
SyncScript->>PublishedDocs: generate variant targets
RouteTests->>PublishedDocs: check published routes and links
PublishedDocs-->>RouteTests: return resolvable route graph
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit f8bdaba in the TypeScript / code-coverage/cliThe overall coverage in commit f8bdaba in the Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-7842.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None 1 optional E2E recommendation
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Summary
This follow-up publishes the OpenShell gateway lifecycle authority and Enterprise Readiness pages in the OpenClaw, Hermes, and Deep Agents guide variants.
It also makes intentional partial publication explicit in source frontmatter and fails the docs build when navigation and source scope differ.
Related Issue
Follow-up to #6576 and #7246.
Changes
docs/deployment/gateway-lifecycle-authority.mdx: Publishes the host-side OpenShell gateway lifecycle contract for every applicable guide variant and distinguishes it from an in-sandbox agent gateway.docs/reference/enterprise-readiness.mdxfor LangChain Deep Agents Code and describes the runtime-specific dashboard, observability, and agent gateway boundaries.agent-variantsdeclarations to 42 intentionally partial source pages. The docs generator compares these declarations withdocs/index.ymlbecause navigation alone cannot distinguish an omission from an intentional subset.Change footprint
This PR changes 52 files, but most of that count is the baseline required by the new validation:
agent-variantsfrontmatter line to existing pages whose publication is intentionally limited to a subset of the OpenClaw, Hermes, and Deep Agents guides. Their documentation content does not change.docs/deployment/gateway-lifecycle-authority.mdx,docs/reference/enterprise-readiness.mdx, anddocs/index.yml..agents/skills/nemoclaw-contributor-update-docs/SKILL.md,docs/AGENTS.md,docs/CONTRIBUTING.md, anddocs/resources/engineer-agentic-documentation.mdx.scripts/sync-agent-variant-docs.mts,test/sync-agent-variant-docs.test.ts, andtest/check-docs-published-routes.test.ts.Miyoung’s documentation-engineering workflow
Miyoung’s documentation-engineering workflow is not a separate bot, service, or scheduled GitHub workflow. It is the repository-owned
nemoclaw-contributor-update-docsskill that she runs daily with Codex Desktop.Before this PR, the skill already knew how to render host CLI names for all three guide variants, but its new-page rule only told the documentation engineer to add the “appropriate navigation entry.” It did not require an explicit applicability decision or a source declaration for an intentional subset. Separately, the generator classified a page as shared by intersecting only the OpenClaw and Hermes navigation, and its guard applied only to pages containing the
$$nemoclawplaceholder. As a result, a generic page with literalnemoclawcommands could be added only to the OpenClaw navigation and still pass the documentation build.This PR changes the workflow at each relevant layer:
.agents/skills/nemoclaw-contributor-update-docs/SKILL.md: Requires the daily documentation scan to determine applicability from implementation, tests, or accepted product scope; publish a page in every applicable guide variant; and declare an intentional subset withagent-variants.docs/AGENTS.md: Gives the same rule to agents while they work underdocs/.docs/CONTRIBUTING.md: Makes the applicability decision and source declaration part of the contributor contract.docs/resources/engineer-agentic-documentation.mdx: Updates the public description of the documentation engine so it no longer says that navigation alone defines variant membership.scripts/sync-agent-variant-docs.mts: Enforces the rule by comparing each source declaration with its actual OpenClaw, Hermes, and Deep Agents navigation membership during the documentation build.There is no separate scheduler to adjust. The documentation-writer receipt continues to verify that review happened on the current head; the new generator check supplies the missing publication-scope control.
Type of Change
Quality Gates
No security behavior or security claim changed.
Documentation Writer Review
docs-updated.agents/skills/nemoclaw-contributor-update-docs/SKILL.md,docs/AGENTS.md,docs/CONTRIBUTING.md,docs/index.yml, the 45 changed MDX source pages, the generator, and the focused tests.The review covered the writing rules, documentation style, guide variant terminology, gateway boundaries, rendered commands, and declared publication scope.
Focused tests passed 36/36, and
npm run docscompleted with 0 errors and 2 pre-existing Fern warnings.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm exec -- vitest run test/sync-agent-variant-docs.test.ts test/check-docs-published-routes.test.tspassed 36/36 tests atf8bdabacc.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Not applicable; this change does not alter broad runtime behavior or the test harness.npm run docsbuilds without warnings (doc changes only) — result: 0 errors and 2 pre-existing Fern warnings.Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit
Documentation
Bug Fixes