test(cli): silence Node 26 JWT bundle loader warnings - #7838
test(cli): silence Node 26 JWT bundle loader warnings#7838VinayBhagavath wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe JWT bundle concurrency test now passes ChangesJWT bundle concurrency test
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
✨ Thanks for the PR. This keeps the JWT bundle test reliable on Node 26 by suppressing loader warnings in the test subprocess. Maintainers will review the test change and Node 26 compatibility. Related open issues: |
|
Release-queue follow-up: this PR is now DIRTY against main. The one-line test-only change still has no actionable CodeRabbit findings, but the exact-head E2E controller for 6551e8e timed out after waiting for a trusted verdict; it did not report a branch test failure. Please update the branch from current main, resolve the conflict with a signed/verified commit, and let the full required matrix rerun on the new exact head. Once it is clean, this should be a small maintainer review. |
cv
left a comment
There was a problem hiding this comment.
Reviewed commit 6551e8ef6. Current main already addresses the Node loader diagnostic at this call site with the narrower --disable-warning=${TSX_LOADER_DEPRECATION} argument. Merging this branch now conflicts with that implementation and would replace targeted suppression with broad --no-warnings, which can hide unrelated diagnostics from the test subprocess. This PR is superseded by current main; close it rather than resolving the conflict.
Summary
Keeps the concurrent gateway JWT bundle test compatible with Node 26. The test subprocess now suppresses Node and loader warnings so its stderr assertion continues to detect only diagnostics from the behavior under test.
Related Issue
Fixes #7837
Changes
--no-warningsto the test-only child Node process that loads TypeScript throughtsx.Type of Change
Quality Gates
Documentation Writer Review
no-docs-needed6551e8ef6bc02ebc4f1413495aa0f1db64b692cconly adds--no-warningsto a test-only Node subprocess;npx vitest run --project cli src/lib/onboard/docker-driver-gateway-jwt-bundle.test.tspassed 12/12.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run --project cli src/lib/onboard/docker-driver-gateway-jwt-bundle.test.ts(12 passed).npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Vinay Bhagavath bhagavathvinay@gmail.com
Summary by CodeRabbit