Skip to content

test(cli): silence Node 26 JWT bundle loader warnings - #7838

Closed
VinayBhagavath wants to merge 1 commit into
NVIDIA:mainfrom
VinayBhagavath:codex/fix-node26-jwt-stderr
Closed

test(cli): silence Node 26 JWT bundle loader warnings#7838
VinayBhagavath wants to merge 1 commit into
NVIDIA:mainfrom
VinayBhagavath:codex/fix-node26-jwt-stderr

Conversation

@VinayBhagavath

@VinayBhagavath VinayBhagavath commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Keeps the concurrent gateway JWT bundle test compatible with Node 26. The test subprocess now suppresses Node and loader warnings so its stderr assertion continues to detect only diagnostics from the behavior under test.

Related Issue

Fixes #7837

Changes

  • Add --no-warnings to the test-only child Node process that loads TypeScript through tsx.
  • Preserve the assertion that each JWT bundle caller exits successfully and produces no application stderr.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: this only changes a test subprocess flag and has no user-facing behavior.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: No documentation paths changed. Commit 6551e8ef6bc02ebc4f1413495aa0f1db64b692cc only adds --no-warnings to a test-only Node subprocess; npx vitest run --project cli src/lib/onboard/docker-driver-gateway-jwt-bundle.test.ts passed 12/12.
  • Agent: NemoClaw documentation writer reviewer (Codex)

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project cli src/lib/onboard/docker-driver-gateway-jwt-bundle.test.ts (12 passed).
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Vinay Bhagavath bhagavathvinay@gmail.com

Summary by CodeRabbit

  • Tests
    • Suppressed Node.js warnings during concurrent JWT bundle test execution for cleaner test output.

@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4ffb3ef3-d57f-451b-bd5a-452148a6e9f9

📥 Commits

Reviewing files that changed from the base of the PR and between 3aea38c and 6551e8e.

📒 Files selected for processing (1)
  • src/lib/onboard/docker-driver-gateway-jwt-bundle.test.ts

📝 Walkthrough

Walkthrough

The JWT bundle concurrency test now passes --no-warnings when spawning its inline tsx/ESM helper process. The subprocess execution and readiness/result collection behavior remain unchanged.

Changes

JWT bundle concurrency test

Layer / File(s) Summary
Suppress spawned-process warnings
src/lib/onboard/docker-driver-gateway-jwt-bundle.test.ts
The child-process spawn arguments include --no-warnings for the inline helper execution.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: brandonpelfrey, cv, dnandakumar-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the test-only change to silence Node 26 JWT bundle loader warnings.
Linked Issues check ✅ Passed The change matches issue #7837 by quieting the JWT bundle subprocess warnings on Node 26 while keeping the test flow intact.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to the focused test helper and introduces no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-onboard

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@wscurran wscurran added area: cli Command line interface, flags, terminal UX, or output area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance labels Jul 29, 2026
@wscurran

Copy link
Copy Markdown
Contributor

✨ Thanks for the PR. This keeps the JWT bundle test reliable on Node 26 by suppressing loader warnings in the test subprocess. Maintainers will review the test change and Node 26 compatibility.


Related open issues:

@apurvvkumaria apurvvkumaria self-assigned this Aug 4, 2026
@cjagwani

cjagwani commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Release-queue follow-up: this PR is now DIRTY against main. The one-line test-only change still has no actionable CodeRabbit findings, but the exact-head E2E controller for 6551e8e timed out after waiting for a trusted verdict; it did not report a branch test failure. Please update the branch from current main, resolve the conflict with a signed/verified commit, and let the full required matrix rerun on the new exact head. Once it is clean, this should be a small maintainer review.

@cv cv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit 6551e8ef6. Current main already addresses the Node loader diagnostic at this call site with the narrower --disable-warning=${TSX_LOADER_DEPRECATION} argument. Merging this branch now conflicts with that implementation and would replace targeted suppression with broad --no-warnings, which can hide unrelated diagnostics from the test subprocess. This PR is superseded by current main; close it rather than resolving the conflict.

@cv cv closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cli Command line interface, flags, terminal UX, or output area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(test): keep JWT bundle subprocesses quiet on Node 26

5 participants