refactor(onboard): use strict runner for provider entry - #7677
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit d1793ee in the TypeScript / code-coverage/cliThe overall coverage in commit d1793ee in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/lib/onboard/machine/core-flow-phases.ts (1)
262-272: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winLink the retirement issue for this transitional fallback.
The comment states good exit criteria ("Remove this fallback once those checks are strict FSM recovery states and legacy machine step mutation is gone") but doesn't reference a tracking issue/PR. Since this PR only migrates the
provider_selectionslice of a larger fallback, the remaining teardown (inference/sandbox/branch/final-handoff states) should be linked to a GitHub issue.As per path instructions, "Retain an old path only for a demonstrated external/persisted-data contract or a bounded confidence/rollback window. Keep the replacement authoritative, freeze the old path against new callers and features, link the retirement issue or PR in GitHub, and state observable exit criteria" and "If a PR intentionally migrates only a slice, it must say so and link the remaining work in GitHub."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/onboard/machine/core-flow-phases.ts` around lines 262 - 272, Update the transitional fallback comment near runLiveOnboardFlowSlice to explicitly link the GitHub issue or PR tracking retirement of the remaining inference, sandbox/branch, and final-handoff fallback states. Preserve the existing exit criteria and clarify that this change migrates only the provider_selection slice while the linked work covers the remaining teardown.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/lib/onboard/machine/core-flow-phases.ts`:
- Around line 262-272: Update the transitional fallback comment near
runLiveOnboardFlowSlice to explicitly link the GitHub issue or PR tracking
retirement of the remaining inference, sandbox/branch, and final-handoff
fallback states. Preserve the existing exit criteria and clarify that this
change migrates only the provider_selection slice while the linked work covers
the remaining teardown.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: aeb7880f-a117-4917-a83d-107ba7bbe0f9
📒 Files selected for processing (2)
src/lib/onboard/machine/core-flow-phases.test.tssrc/lib/onboard/machine/core-flow-phases.ts
be3764a
into
codex/onboard-fsm-core-effect-boundary
wscurran
added
area: onboarding
2 participants
Summary
This final stack layer makes exact
provider_selectionentries use the strict FSM runner for fresh and resumed sessions. Compatibility replay remains for saved sessions already atinference,sandbox, a branch state, or a final-flow handoff state.Stack layer 6 of 6. Base:
codex/onboard-fsm-core-effect-boundary.Related Issue
Refs #6224
Changes
provider_selectionfrom the resume compatibility state set.Type of Change
Quality Gates
Documentation Writer Review
no-docs-neededDGX Station Hardware Evidence
scripts/prepare-dgx-station-host.shis unchanged.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Bug Fixes
Tests