docs(reference): correct NEMOCLAW_CONFIG_ACCEPT_NEW_PATH and document config set - #7572
docs(reference): correct NEMOCLAW_CONFIG_ACCEPT_NEW_PATH and document config set#7572harjothkhara wants to merge 2 commits into
Conversation
… config set The environment variable row described the variable as accepting a new sandbox config path when the stored path differs from the discovered one. It actually gates writing a config key dotpath that does not yet exist in the sandbox config, and it applies only to `config set`, not onboarding. Move the row from Onboarding Behavior Flags to Lifecycle Behavior Flags, correct the description, and add a `config set` reference section so the matching `--config-accept-new-path` flag is documented. Signed-off-by: harjoth <harjoth.khara@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated command and environment-variable documentation for sandbox configuration writes, protected gateway paths, new-dotpath confirmation, lifecycle flag precedence, and OpenClaw/Hermes onboarding validation skips. ChangesConfiguration Documentation
Estimated code review effort: 2 (Simple) | ~5–15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None 1 optional E2E recommendation
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/commands.mdx`:
- Line 3856: Update the NEMOCLAW_CONFIG_ACCEPT_NEW_PATH documentation to
describe the accepted value as the code-formatted string "1", replacing the
unquoted numeric wording while preserving the existing strict opt-in behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 363919b4-5ec6-4153-800b-88c975f83246
📒 Files selected for processing (1)
docs/reference/commands.mdx
…alue Address CodeRabbit review feedback on NVIDIA#7572. The gate compares the raw environment string, so document the accepted value as "1". Signed-off-by: harjoth <harjoth.khara@gmail.com>
|
Superseded by #7565, which now carries this docs change alongside the code fix it documents. |
1 participant
Summary
The
NEMOCLAW_CONFIG_ACCEPT_NEW_PATHreference row describes behavior the variable does not have, and it sits in the wrong table. The variable gates writing a config key dotpath that does not yet exist in the sandbox config duringnemoclaw <name> config set. It has nothing to do with a filesystem config path, and it does not affect onboarding. This corrects the row, moves it to the table it belongs in, and adds the missingconfig setreference section so the matching--config-accept-new-pathflag is documented.Related Issue
None.
Changes
NEMOCLAW_CONFIG_ACCEPT_NEW_PATHdescription indocs/reference/commands.mdx. The previous text said the variable "accepts a new sandbox config path ... when the stored path differs from the discovered one". The gate isclassifyNewKeyGateinsrc/lib/sandbox/config.ts:425, called fromconfigSetatsrc/lib/sandbox/config.ts:1164underif (oldValue === undefined), so it gates a config key dotpath that does not already exist, not a filesystem path.configSet, which manages an existing sandbox, and the surrounding onboarding table says to set those flags before runningonboard.classifyNewKeyGatematchesacceptEnv === "1"only, andtest/config-set.test.tsasserts thattrue,yes, and empty are not accepted.nemoclaw <name> config setreference section next to the existingconfig getsection under Advanced Sandbox Maintenance Commands.--config-accept-new-pathpreviously appeared nowhere underdocs/, becauseconfig sethad no reference section to hold it. Flag descriptions match the oclif definitions insrc/commands/sandbox/config/set.ts.No new abstraction, configuration, fallback, or compatibility path. This documents existing shipped behavior.
Type of Change
Quality Gates
docs/reference/commands.mdx. No runtime behavior changes. The behavior now described correctly is already covered by theclassifyNewKeyGatetests intest/config-set.test.ts.Documentation Writer Review
docs-updateddocs/reference/commands.mdx. The reviewer checked the change against the writing rules and documentation style indocs/CONTRIBUTING.mdandWRITING.md, and its findings were applied: passive voice removed from the--valueand new-dotpath descriptions, one term ("dotpath") used for one concept, the URL validation sentence split, theNEMOCLAW_NON_INTERACTIVE=1refusal case added, and the env-var Effect cell reworded to match the verb register of the surrounding rows.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only) —npm run docsreportsFound 0 errors and 2 warnings. Both warnings are pre-existing: the same count comes back when the file is reverted toorigin/main.Signed-off-by: harjoth harjoth.khara@gmail.com
Summary by CodeRabbit
$$nemoclaw <name> config set, including HTTPS/URL validation, required shield state before writes, and handling of non-existent dotpaths.--restartand--config-accept-new-path, including stricter opt-in semantics and precedence with non-interactive mode.gateway/gateway.*and pointed to token-rotation guidance.NEMOCLAW_CONFIG_ACCEPT_NEW_PATH.