Skip to content

fix(ci): install hadolint for docs-only checks #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 1 commit into from
Jul 25, 2026
Merged

fix(ci): install hadolint for docs-only checks #7536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@ jobs:
- name: Install docs-only check dependencies
run: npm install --ignore-scripts

- name: Install hadolint
shell: bash
run: |
set -euo pipefail
HADOLINT_VERSION="v2.14.0"
HADOLINT_URL="https://github.com/hadolint/hadolint/releases/download/${HADOLINT_VERSION}/hadolint-linux-x86_64"
HADOLINT_SHA256="6bf226944684f56c84dd014e8b979d27425c0148f61b3bd99bcc6f39e9dc5a47"
curl -fsSL -o /usr/local/bin/hadolint "$HADOLINT_URL"
ACTUAL=$(sha256sum /usr/local/bin/hadolint | awk '{print $1}')
[ "$HADOLINT_SHA256" = "$ACTUAL" ] || { echo "::error::hadolint checksum mismatch"; exit 1; }
chmod +x /usr/local/bin/hadolint

- name: Fetch checked-out merge base for docs-only checks
shell: bash
run: |
Expand Down
13 changes: 6 additions & 7 deletions test/pr-workflow-contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,13 +1119,12 @@ describe("pull request and main workflow contracts", () => {

// source-shape-contract: security -- Downloaded CI tooling must use a committed digest rather than upstream metadata
it("pins downloaded CI tooling to reviewed integrity", () => {
const staticRunsJoined = stepRuns(sharedActions.staticChecks).join("\n");

expect(staticRunsJoined).toContain(
'HADOLINT_SHA256="6bf226944684f56c84dd014e8b979d27425c0148f61b3bd99bcc6f39e9dc5a47"',
);
expect(staticRunsJoined).not.toContain('"${HADOLINT_URL}.sha256"');
expect(staticRunsJoined).not.toContain("EXPECTED=$(curl");
const docsRuns = stepRuns(prWorkflow.jobs["docs-only-checks"]).join("\n");
for (const runs of [stepRuns(sharedActions.staticChecks).join("\n"), docsRuns]) {
expect(runs).toContain("6bf226944684f56c84dd014e8b979d27425c0148f61b3bd99bcc6f39e9dc5a47");
expect(runs).not.toMatch(/HADOLINT_URL.*sha256|EXPECTED=\$\(curl/);
}
expect(docsRuns.indexOf("HADOLINT_SHA256")).toBeLessThan(docsRuns.indexOf("prek run"));
});

it("validates CLI shard inputs before using them in shell commands", () => {
Expand Down
Loading