Skip to content

fix(sandbox): strip group-write from staged Docker payloads #7514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senthilr-nv merged 2 commits into from
Jul 25, 2026
Merged

fix(sandbox): strip group-write from staged Docker payloads #7514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
833589e
fix(sandbox): strip group-write from staged Docker payloads
senthilr-nv Jul 25, 2026
14967c5
merge(main): refresh sandbox build-context fix
senthilr-nv Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/sandbox/build-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function createBuildContextDir(tmpDir: string = os.tmpdir()): string {
function normalizeReadModesForDockerCopy(rootDir: string): void {
const stat = fs.lstatSync(rootDir);
if (stat.isDirectory()) {
fs.chmodSync(rootDir, (stat.mode & 0o777) | 0o555);
fs.chmodSync(rootDir, (stat.mode & 0o777 & ~0o022) | 0o555);
for (const entry of fs.readdirSync(rootDir)) {
normalizeReadModesForDockerCopy(path.join(rootDir, entry));
}
Expand All @@ -36,7 +36,7 @@ function normalizeReadModesForDockerCopy(rootDir: string): void {

if (stat.isFile()) {
const mode = stat.mode & 0o777;
fs.chmodSync(rootDir, mode | 0o444 | (mode & 0o111 ? 0o111 : 0));
fs.chmodSync(rootDir, (mode & ~0o022) | 0o444 | (mode & 0o111 ? 0o111 : 0));
}
}

Expand Down
73 changes: 72 additions & 1 deletion test/sandbox-build-context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,19 @@ describe("sandbox build context staging", () => {
fs.chmodSync(path.join(sourceRoot, "scripts", "lib"), 0o700);
}

function makeBuildContextFixtureGroupWritable(sourceRoot: string) {
for (const relativePath of [
"scripts",
path.join("scripts", "lib"),
"src",
path.join("src", "lib"),
]) {
fs.chmodSync(path.join(sourceRoot, relativePath), 0o775);
}
fs.chmodSync(path.join(sourceRoot, "scripts", "patch-bundled-npm-tar.mts"), 0o775);
fs.chmodSync(path.join(sourceRoot, "src", "lib", "tool-disclosure.ts"), 0o664);
}

function expectDockerfileScriptCopiesExist(buildCtx: string, stagedDockerfile: string) {
const dockerfile = fs.readFileSync(stagedDockerfile, "utf8");
const copiedScripts = [...dockerfile.matchAll(/^COPY\s+scripts\/(\S+)/gm)].map(
Expand Down Expand Up @@ -210,32 +223,58 @@ describe("sandbox build context staging", () => {
expect((fs.statSync(stagedHelper).mode & 0o777).toString(8)).toBe("755");
}

it("normalizes copied blueprint modes with chmod a+rX semantics", () => {
function expectStagedGroupWritablePayloadModes(buildCtx: string) {
expect((fs.statSync(path.join(buildCtx, "scripts")).mode & 0o777).toString(8)).toBe("755");
expect(
(
fs.statSync(path.join(buildCtx, "scripts", "patch-bundled-npm-tar.mts")).mode & 0o777
).toString(8),
).toBe("755");
expect(
(fs.statSync(path.join(buildCtx, "src", "lib", "tool-disclosure.ts")).mode & 0o777).toString(
8,
),
).toBe("644");
}

it("normalizes restrictive and group-writable modes for Docker COPY", () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-build-context-unit-"));
const blueprintDir = path.join(tmpDir, "nemoclaw-blueprint");
const manifestDir = path.join(blueprintDir, "model-specific-setup", "openclaw");
const manifestPath = path.join(manifestDir, "kimi-k2.6-managed-inference.json");
const executablePath = path.join(blueprintDir, "scripts", "helper.sh");
const groupWritableDir = path.join(blueprintDir, "group-writable");
const groupWritableFile = path.join(groupWritableDir, "manifest.json");
const groupWritableExecutable = path.join(groupWritableDir, "helper.sh");
const symlinkPath = path.join(blueprintDir, "manifest-link.json");

try {
fs.mkdirSync(manifestDir, { recursive: true });
fs.mkdirSync(path.dirname(executablePath), { recursive: true });
fs.mkdirSync(groupWritableDir, { mode: 0o775 });
fs.writeFileSync(manifestPath, "{}\n", { mode: 0o600 });
fs.writeFileSync(executablePath, "#!/bin/sh\n", { mode: 0o700 });
fs.writeFileSync(groupWritableFile, "{}\n", { mode: 0o664 });
fs.writeFileSync(groupWritableExecutable, "#!/bin/sh\n", { mode: 0o775 });
fs.symlinkSync(manifestPath, symlinkPath);
fs.chmodSync(blueprintDir, 0o700);
fs.chmodSync(path.join(blueprintDir, "model-specific-setup"), 0o700);
fs.chmodSync(manifestDir, 0o700);
fs.chmodSync(manifestPath, 0o600);
fs.chmodSync(executablePath, 0o700);
fs.chmodSync(groupWritableDir, 0o775);
fs.chmodSync(groupWritableFile, 0o664);
fs.chmodSync(groupWritableExecutable, 0o775);

normalizeReadModesForDockerCopy(blueprintDir);

expect((fs.statSync(blueprintDir).mode & 0o777).toString(8)).toBe("755");
expect((fs.statSync(manifestDir).mode & 0o777).toString(8)).toBe("755");
expect((fs.statSync(manifestPath).mode & 0o777).toString(8)).toBe("644");
expect((fs.statSync(executablePath).mode & 0o777).toString(8)).toBe("755");
expect((fs.statSync(groupWritableDir).mode & 0o777).toString(8)).toBe("755");
expect((fs.statSync(groupWritableFile).mode & 0o777).toString(8)).toBe("644");
expect((fs.statSync(groupWritableExecutable).mode & 0o777).toString(8)).toBe("755");
expect(fs.lstatSync(symlinkPath).isSymbolicLink()).toBe(true);
} finally {
fs.rmSync(tmpDir, { recursive: true, force: true });
Expand Down Expand Up @@ -344,6 +383,38 @@ describe("sandbox build context staging", () => {
}
});

it("optimized staging strips group and other write bits from copied payloads", () => {
const sourceRoot = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-build-context-source-"));
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-build-context-group-write-"));

try {
writeBuildContextFixture(sourceRoot);
makeBuildContextFixtureGroupWritable(sourceRoot);
const { buildCtx } = stageOptimizedSandboxBuildContext(sourceRoot, tmpDir);
expectStagedGroupWritablePayloadModes(buildCtx);
} finally {
fs.rmSync(sourceRoot, { recursive: true, force: true });
fs.rmSync(tmpDir, { recursive: true, force: true });
}
});

it("legacy staging strips group and other write bits from copied payloads", () => {
const sourceRoot = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-build-context-source-"));
const tmpDir = fs.mkdtempSync(
path.join(os.tmpdir(), "nemoclaw-build-context-legacy-group-write-"),
);

try {
writeBuildContextFixture(sourceRoot);
makeBuildContextFixtureGroupWritable(sourceRoot);
const { buildCtx } = stageLegacySandboxBuildContext(sourceRoot, tmpDir);
expectStagedGroupWritablePayloadModes(buildCtx);
} finally {
fs.rmSync(sourceRoot, { recursive: true, force: true });
fs.rmSync(tmpDir, { recursive: true, force: true });
}
});

it("optimized staging excludes blueprint .venv and extra scripts while preserving required files", () => {
const repoRoot = path.join(import.meta.dirname, "..");
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-build-context-opt-"));
Expand Down
Loading