Skip to content

refactor(e2e): remove candidate Hermes swap setup #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 2 commits into from
Jul 24, 2026
Merged

refactor(e2e): remove candidate Hermes swap setup #7460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cedae38
refactor(e2e): remove candidate Hermes swap setup
prekshivyas Jul 24, 2026
64436ae
Merge branch 'main' into codex/remove-candidate-hermes-swap
prekshivyas Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions test/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ Hermes image-building lanes that remain on those standard runners. The trusted
workflow provisions the fallback as the first job step, before checking out or
executing the candidate revision. It requires a controller-supplied lowercase
40-hex checkout SHA, matching trusted workflow and dispatch revisions, and an
ephemeral GitHub-hosted Linux x64 runner.
ephemeral GitHub-hosted Linux x64 runner. Candidate code cannot supply the
program or arguments passed to `sudo`.

The trusted step requires at least 32 GiB (34,359,738,368 bytes) of usable swap.
It reuses active swap that meets this requirement.
Expand All @@ -79,23 +80,12 @@ The additional 4,096 bytes keep the usable swap capacity at or above 32 GiB
after formatting.
Setup failure stops before candidate checkout and removes partial state only
after proving the file inactive or successfully disabling it.
After `swapon` succeeds, both rollout paths make up to five activation
After `swapon` succeeds, the trusted step makes up to five activation
observations, one second apart.
If visibility remains stale, cleanup treats the file as active.
Cleanup removes it only after `swapoff` succeeds.
Successful state is discarded with the ephemeral runner.

This rollout adds the trusted pre-checkout setup.
During rollout, the PR temporarily retains the reviewed live Vitest helper.
The helper exists only because the PR must validate against the older workflow
definition on `main` before this change lands.
The compatibility path runs only when GitHub Actions supplies a validated
lowercase 40-hex checkout SHA.
When the trusted step already provides 32 GiB of usable swap, the helper exits
before it creates its fixed swap file.
A follow-up must remove the candidate-side helper and its compatibility tests
after this change lands.

The fallback covers agent-turn latency, Hermes inference switch and shields,
the Hermes Bedrock and stable MCP shards, and the `hermes-e2e`,
`hermes-dashboard`, and Hermes security-posture tests. Scheduled and ordinary
Expand Down
Loading
Loading