Skip to content

test(hermes): stabilize guard timing and WSL ownership #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 4 commits into from
Jul 22, 2026
Merged

test(hermes): stabilize guard timing and WSL ownership #7381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
532e160
test(hermes): allow slow config guard helpers
ericksoa Jul 22, 2026
6a8995c
test(wsl): model Hermes sandbox group ownership
ericksoa Jul 22, 2026
8ee5fca
chore(ci): merge main into Hermes guard stabilization
ericksoa Jul 22, 2026
b7414d2
test(wsl): allow config reclaim peer traversal
ericksoa Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/helpers/hermes-restart-config-seal-fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export const RUNTIME_CONFIG_GUARD = path.join(
"runtime-config-guard.py",
);

const HERMES_GUARD_TIMEOUT_MS = 90_000;

export interface RestartFixture {
root: string;
sandboxDir: string;
Expand Down Expand Up @@ -123,7 +125,7 @@ export function runWriteConfig(fixture: RestartFixture, expectedDigest: string,
"--expected-config-sha256",
expectedDigest,
],
{ encoding: "utf-8", input: content, timeout: 5000 },
{ encoding: "utf-8", input: content, timeout: HERMES_GUARD_TIMEOUT_MS },
);
}

Expand Down Expand Up @@ -155,7 +157,7 @@ export function runGuard(action: "seal-restart" | "unseal-restart", fixture: Res
args.push(...(action === "seal-restart" ? ["--hash-file", fixture.hashPath] : []));
return spawnSync("python3", args, {
encoding: "utf-8",
timeout: 5000,
timeout: HERMES_GUARD_TIMEOUT_MS,
});
}

Expand Down Expand Up @@ -231,7 +233,10 @@ export function runShieldsTransactionAction(
...(options.rollbackMode ? ["--rollback-shields-mode", options.rollbackMode] : []),
...(options.token ? ["--lock-token", options.token] : []),
);
return spawnSync("python3", args, { encoding: "utf-8", timeout: 5000 });
return spawnSync("python3", args, {
encoding: "utf-8",
timeout: HERMES_GUARD_TIMEOUT_MS,
});
}

export function strictHashIsValid(fixture: RestartFixture): boolean {
Expand Down
45 changes: 43 additions & 2 deletions test/hermes-restart-config-seal-recovery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,17 +359,47 @@ describe.skipIf(process.platform === "win32")("Hermes mutable restart input seal
let restoreTempRootMode: (() => void) | undefined;

try {
const sandboxUidResult = spawnSync("id", ["-u", "sandbox"], {
encoding: "utf-8",
timeout: 5000,
});
const sandboxGidResult = spawnSync("id", ["-g", "sandbox"], {
encoding: "utf-8",
timeout: 5000,
});
expect(sandboxUidResult.status, sandboxUidResult.stderr).toBe(0);
expect(sandboxGidResult.status, sandboxGidResult.stderr).toBe(0);
Comment on lines +362 to +371

@coderabbitai coderabbitai Bot Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Include the sandbox account in the capability gate.

The existing it.runIf condition checks Linux, root, and setpriv, but not whether the sandbox user/group exists. On a runner lacking that account, both id calls fail and the test fails instead of being skipped. Add equivalent id -u/-g sandbox checks to the gate or provision the account in CI.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/hermes-restart-config-seal-recovery.test.ts` around lines 362 - 371, The
capability gate for this test must also verify that the sandbox account exists
before running. Update the surrounding it.runIf condition to include successful
id -u sandbox and id -g sandbox checks, reusing the same command options as the
existing sandboxUidResult and sandboxGidResult calls so unsupported runners skip
the test.

const sandboxUid = Number(sandboxUidResult.stdout.trim());
const sandboxGid = Number(sandboxGidResult.stdout.trim());
expect(Number.isSafeInteger(sandboxUid)).toBe(true);
expect(Number.isSafeInteger(sandboxGid)).toBe(true);

for (const pathname of [
fixture.sandboxDir,
fixture.hermesDir,
fixture.configPath,
fixture.envPath,
fixture.compatHashPath,
]) {
fs.chownSync(pathname, sandboxUid, sandboxGid);
}
// chown clears setgid, so restore the canonical mutable Hermes mode.
fs.chmodSync(fixture.hermesDir, 0o3770);

restoreTempRootMode = allowRestartFixturePeerTraversal(fixture);
const sealed = runGuard("seal-restart", fixture);
expect(sealed.status, sealed.stderr).toBe(0);

const hermesGid = fs.statSync(fixture.hermesDir).gid;
const sealedHermes = fs.statSync(fixture.hermesDir);
expect(sealedHermes.uid).toBe(0);
expect(sealedHermes.gid).toBe(sandboxGid);
expect(mode(fixture.hermesDir)).toBe(0o3770);
const peer = spawnSync(
"setpriv",
[
"--reuid=65534",
"--regid=65534",
`--groups=${hermesGid}`,
`--groups=${sandboxGid}`,
"sh",
"-c",
'touch "$1/peer-runtime-state" || exit 10; rm "$1/config.yaml" 2>/dev/null && exit 20; test -f "$1/config.yaml"',
Expand All @@ -385,6 +415,17 @@ describe.skipIf(process.platform === "win32")("Hermes mutable restart input seal

const unsealed = runGuard("unseal-restart", fixture);
expect(unsealed.status, unsealed.stderr).toBe(0);
for (const pathname of [
fixture.sandboxDir,
fixture.hermesDir,
fixture.configPath,
fixture.envPath,
fixture.compatHashPath,
]) {
const restored = fs.statSync(pathname);
expect(restored.uid).toBe(sandboxUid);
expect(restored.gid).toBe(sandboxGid);
}
} finally {
try {
fs.rmSync(fixture.root, { recursive: true, force: true });
Expand Down
32 changes: 23 additions & 9 deletions test/nemoclaw-start-perms.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,15 +594,29 @@ describe("nemoclaw-start mutable config reclaim", () => {
expect(fs.statSync(configDir).uid.toString()).toBe(nobodyUid);
expect(fs.statSync(configDir).gid.toString()).toBe(nobodyGid);

const writeCheck = spawnSync("setpriv", [
`--reuid=${nobodyUid}`,
`--regid=${nobodyGid}`,
"--clear-groups",
"--",
"touch",
path.join(configDir, "nemoclaw-write-check"),
]);
expect(writeCheck.status).toBe(0);
const tempRoot = path.dirname(root);
const tempRootMode = mode(tempRoot);
const writeCheck = (() => {
// Vitest's shared temp root is private; expose traversal only for this peer probe.
fs.chmodSync(tempRoot, tempRootMode | 0o001);
try {
return spawnSync(
"setpriv",
[
`--reuid=${nobodyUid}`,
`--regid=${nobodyGid}`,
"--clear-groups",
"--",
"touch",
path.join(configDir, "nemoclaw-write-check"),
],
{ encoding: "utf-8" },
);
} finally {
fs.chmodSync(tempRoot, tempRootMode);
}
})();
expect(writeCheck.status, writeCheck.stderr).toBe(0);
} finally {
fs.rmSync(root, { recursive: true, force: true });
}
Expand Down
Loading