Repository navigation
fix(cli): stop detached Hermes forward watcher during uninstall #7184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7c6f99b
fix(cli): stop detached Hermes forward watcher during uninstall
laitingsheng 7486fec
fix(uninstall): harden Hermes forward watcher cleanup
apurvvkumaria e7fdddf
docs(uninstall): clarify Hermes watcher cleanup
apurvvkumaria 0958a8f
test(uninstall): cover Hermes watcher cleanup retry
apurvvkumaria 26d7d4c
fix(uninstall): preserve uncertain watcher state
apurvvkumaria c5793f0
Merge branch 'main' into fix/hermes-forward-watcher-uninstall
cv e23db39
Merge branch 'main' into fix/hermes-forward-watcher-uninstall
cv 623419f
fix(uninstall): normalize Hermes watcher executable
cv c12d431
Merge branch 'main' into fix/hermes-forward-watcher-uninstall
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/lib/actions/uninstall/hermes-forward-watcher-cleanup.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { | ||
| type HermesForwardWatcherHost, | ||
| stopHermesForwardWatcherProcess, | ||
| stopHermesSandboxForward, | ||
| } from "../../adapters/openshell/hermes-forward-watcher"; | ||
| import { readHermesForwardWatcherState } from "../../state/hermes-forward-watcher"; | ||
|
|
||
| export function stopHermesForwardWatchers( | ||
| nemoclawStateDir: string, | ||
| host: HermesForwardWatcherHost, | ||
| ): boolean { | ||
| const state = readHermesForwardWatcherState(nemoclawStateDir); | ||
| if (!state.readable) { | ||
| host.warn(`Failed to inspect Hermes forward watcher state under ${nemoclawStateDir}.`); | ||
| return false; | ||
| } | ||
| if (state.watchers.length === 0) { | ||
| host.log("No Hermes forward watchers found"); | ||
| return true; | ||
| } | ||
|
|
||
| let allStopped = true; | ||
| for (const watcher of state.watchers) { | ||
| if (!stopHermesForwardWatcherProcess(watcher, host)) allStopped = false; | ||
| if (!stopHermesSandboxForward(watcher, host)) allStopped = false; | ||
| } | ||
| return allStopped; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.