Skip to content

fix(inference): sanitize route display output #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apurvvkumaria wants to merge 1 commit into from
Closed

fix(inference): sanitize route display output #7170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/lib/actions/inference-get.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,22 @@ describe("runInferenceGet", () => {
});
});

it("sanitizes route values only for human-readable output", async () => {
const deps = createDeps(
"Gateway inference:\n Provider: openai\u001b[2J\n Model: gpt\u0007-5.4\r\n",
);

await expect(runInferenceGet({}, deps)).resolves.toEqual({
provider: "openai\u001b[2J",
model: "gpt\u0007-5.4",
});

expect(deps.log.mock.calls.map(([line]) => line)).toEqual([
"Provider: openai[2J",
"Model: gpt-5.4",
]);
});

it("can return the route without rendering output for oclif JSON handling", async () => {
const deps = createDeps("Gateway inference:\n Provider: openai-api\n Model: gpt-5.4\n");

Expand Down
9 changes: 7 additions & 2 deletions src/lib/actions/inference-get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import { captureOpenshell } from "../adapters/openshell/runtime";
import { OPENSHELL_PROBE_TIMEOUT_MS } from "../adapters/openshell/timeouts";
import { sanitizeRouteValueForDisplay } from "../inference/config";
import { getLiveGatewayInference } from "../inference/live";

export interface InferenceGetOptions {
Expand Down Expand Up @@ -59,10 +60,14 @@ export async function runInferenceGet(
if (options.json) {
deps.log(JSON.stringify(payload, null, 2));
} else {
deps.log(`Provider: ${payload.provider ?? "unknown"}`);
deps.log(`Model: ${payload.model ?? "unknown"}`);
deps.log(`Provider: ${formatRouteValueForDisplay(payload.provider)}`);
deps.log(`Model: ${formatRouteValueForDisplay(payload.model)}`);
}
}

return payload;
}

function formatRouteValueForDisplay(value: string | null): string {
return sanitizeRouteValueForDisplay(value) || "unknown";
}