-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(sandbox): export HTTP_PROXY/HTTPS_PROXY/NO_PROXY so Node.js routes through OpenShell egress proxy (fixes #626) #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
nanookclaw
wants to merge
4
commits into
NVIDIA:main
from
nanookclaw:fix/sandbox-dns-resolution-proxy-env
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
88e573a
fix(sandbox): export HTTP_PROXY/HTTPS_PROXY/NO_PROXY for Node.js DNS …
nanookclaw 623d878
test(sandbox): source proxy vars from nemoclaw-start.sh instead of du…
nanookclaw c81cb4f
fix(sandbox): replace CIDR in NO_PROXY with explicit gateway IP; add …
nanookclaw b820c9c
fix(sandbox): write proxy env to /etc/profile.d so connected shells i…
nanookclaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NO_PROXYhardcodes10.200.0.1instead of using${PROXY_HOST}.Lines 154 and 166 hardcode
10.200.0.1inNO_PROXY, whileHTTP_PROXYandHTTPS_PROXYuse the configurable${PROXY_HOST}. If a user overridesNEMOCLAW_PROXY_HOSTto a different IP, the proxy host won't be bypassed, potentially causing requests to the proxy to be routed through itself.🐛 Proposed fix for consistency
And in the heredoc (line 166):
Also applies to: 166-166
🤖 Prompt for AI Agents