fix(install): notice acceptance must not imply non-interactive for --station-deepseek (#7008) - #7012
fix(install): notice acceptance must not imply non-interactive for --station-deepseek (#7008)#7012yanyunl1991 wants to merge 1 commit into
Conversation
…--station-deepseek (#7008) NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 (and --yes-i-accept-third-party-software) inferred non-interactive mode, which then made validate_station_deepseek_override reject --station-deepseek -- a flag that explicitly selects the interactive DGX Station express prompt. So the documented curl-pipe install aborted immediately: [ERROR] --station-deepseek selects the DGX Station express prompt and cannot be combined with --non-interactive. The two signals are orthogonal: one accepts a licence, the other opts into an interactive express flow. Skip the notice->non-interactive inference when --station-deepseek is set so the express prompt is reached. The inference (and its #4414/#2671 partial-install protection) is unchanged for every other install. Verified on a DGX-Station-mocked aarch64 host: the reported command now proceeds past the express preflight without inferring non-interactive. Signed-off-by: Yanyun Liao <yanyunl@nvidia.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. Since last review: 0 prior items resolved · 0 still apply · 0 new items found E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Summary
The documented DGX Station curl-pipe install aborted immediately:
curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.84 NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 bash -s -- --station-deepseekNEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1(and--yes-i-accept-third-party-software) inferredNON_INTERACTIVE=1, which then madevalidate_station_deepseek_overridereject--station-deepseek— a flag that explicitly selects the interactive DGX Station express prompt. The two signals are orthogonal: one accepts a licence, the other opts into an interactive flow.Fix
Skip the notice→non-interactive inference when
--station-deepseekis set. The inference (and its #4414/#2671 partial-install protection) is preserved for every other install.Verification (DGX-Station-mocked aarch64)
Drove
mainwith the platform mocked toDGX Station, stopping right after the express preflight:NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1+--station-deepseek→ proceeds past the preflight,NON_INTERACTIVEstays unset (was: aborted).--station-deepseek→ still implies non-interactive (regression preserved by the existing tests).New test case in
test/install-express-prompt.test.ts.Companion to #7009 (which improves the conflict error message); kept as a separate PR per issue. This PR does not change the error message.
Fixes #7008.
Signed-off-by: Yanyun Liao yanyunl@nvidia.com
🤖 Generated with Claude Code