Skip to content

fix(install): notice acceptance must not imply non-interactive for --station-deepseek (#7008) - #7012

Closed
yanyunl1991 wants to merge 1 commit into
mainfrom
fix/7008-decouple-notice-station-deepseek
Closed

fix(install): notice acceptance must not imply non-interactive for --station-deepseek (#7008)#7012
yanyunl1991 wants to merge 1 commit into
mainfrom
fix/7008-decouple-notice-station-deepseek

Conversation

@yanyunl1991

Copy link
Copy Markdown
Contributor

Summary

The documented DGX Station curl-pipe install aborted immediately:

curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.84 NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 bash -s -- --station-deepseek
[ERROR] --station-deepseek selects the DGX Station express prompt and cannot be combined with --non-interactive.

NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 (and --yes-i-accept-third-party-software) inferred NON_INTERACTIVE=1, which then made validate_station_deepseek_override reject --station-deepseek — a flag that explicitly selects the interactive DGX Station express prompt. The two signals are orthogonal: one accepts a licence, the other opts into an interactive flow.

Fix

Skip the notice→non-interactive inference when --station-deepseek is set. The inference (and its #4414/#2671 partial-install protection) is preserved for every other install.

Verification (DGX-Station-mocked aarch64)

Drove main with the platform mocked to DGX Station, stopping right after the express preflight:

  • NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 + --station-deepseekproceeds past the preflight, NON_INTERACTIVE stays unset (was: aborted).
  • notice acceptance without --station-deepseek → still implies non-interactive (regression preserved by the existing tests).

New test case in test/install-express-prompt.test.ts.

Companion to #7009 (which improves the conflict error message); kept as a separate PR per issue. This PR does not change the error message.

Fixes #7008.

Signed-off-by: Yanyun Liao yanyunl@nvidia.com

🤖 Generated with Claude Code

…--station-deepseek (#7008)

NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 (and --yes-i-accept-third-party-software)
inferred non-interactive mode, which then made validate_station_deepseek_override
reject --station-deepseek -- a flag that explicitly selects the interactive DGX
Station express prompt. So the documented curl-pipe install aborted immediately:

  [ERROR] --station-deepseek selects the DGX Station express prompt and cannot be
  combined with --non-interactive.

The two signals are orthogonal: one accepts a licence, the other opts into an
interactive express flow. Skip the notice->non-interactive inference when
--station-deepseek is set so the express prompt is reached. The inference (and
its #4414/#2671 partial-install protection) is unchanged for every other install.

Verified on a DGX-Station-mocked aarch64 host: the reported command now proceeds
past the express preflight without inferring non-interactive.

Signed-off-by: Yanyun Liao <yanyunl@nvidia.com>
@github-code-quality

github-code-quality Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the main branch.

TypeScript / code-coverage/cli

The overall coverage in the fix/7008-decouple-no... branch remains at 80%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.
File main b528371 fix/7008-decouple-no... daf94ff +/-
src/lib/inferen...lama/process.ts 100% 50% -50%
src/lib/inferen...er-lifecycle.ts 71% 65% -6%

Updated July 16, 2026 10:13 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

Since last review: 0 prior items resolved · 0 still apply · 0 new items found

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-onboard

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@yanyunl1991

Copy link
Copy Markdown
Contributor Author

Consolidating back into a single combined PR #7010 (covers both #7008 and #7009). Closing this split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DGX Station][Install] express install --station-deepseek fails with non-interactive conflict when NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 is set

2 participants