test(e2e): make inference switch baselines sandbox-reachable - #6989
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Hermes and OpenClaw live inference-switch tests now configure baseline fake OpenAI-compatible servers with explicit binding and public host values for gateway network-namespace reachability. ChangesInference fixture networking
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / medium confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: 1 warning · 0 suggestionsWarningsWarnings do not block.
|
|
Reviewed
These two servers are short-lived CI fixtures, require a fixed non-secret test credential for inference, and expose no user data or production credential. This PR does not change any production listener or policy. If the project wants interface-specific binding, it should be designed once as a cross-platform fixture hardening change for all existing host-bridge test servers rather than applied inconsistently at these two call sites. |
Summary
Make the mock OpenAI-compatible baselines in the OpenClaw and Hermes inference-switch live E2E targets reachable from the OpenShell gateway. Previously the runner-side smoke probe passed against loopback, but sandbox deployment verification returned HTTP 503 because the gateway could not reach the runner's loopback address.
Changes
0.0.0.0while advertisinghost.openshell.internalto OpenShell.Type of Change
Quality Gates
host.openshell.internalfor sandbox-to-host inference routes.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run --project e2e-support test/e2e/support/e2e-cleanup-resources.test.ts test/e2e/support/e2e-clients.test.ts(2 files, 70 tests passed). The exact live targets require external state and are left to the E2E workflow.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Not applicable to this focused live E2E configuration change. A broadere2e-supportrun was attempted; the mapped tests passed, while 12 unrelated workflow-boundary subprocess timeout failures occurred across five unchanged files.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Prekshi Vyas prekshiv@nvidia.com
Summary by CodeRabbit