Skip to content

fix(security): verify SHA-256 checksum on OpenShell binary download #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericksoa merged 5 commits into from
Mar 30, 2026
Merged

fix(security): verify SHA-256 checksum on OpenShell binary download #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
223e46e
fix(security): verify SHA-256 checksum on OpenShell binary download
ericksoa Mar 23, 2026
1c9038c
Merge branch 'main' into fix/openshell-checksum-verify
ericksoa Mar 25, 2026
8b8574d
Merge branch 'main' into fix/openshell-checksum-verify
cv Mar 25, 2026
1b42cf5
Merge remote-tracking branch 'origin/main' into fix/openshell-checksu…
ericksoa Mar 30, 2026
2f34212
fix(security): address review feedback on checksum verification
ericksoa Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/install-openshell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,23 @@ esac
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT

CHECKSUM_FILE="openshell-checksums-sha256.txt"
if command -v gh >/dev/null 2>&1; then
GH_TOKEN="${GITHUB_TOKEN:-}" gh release download --repo NVIDIA/OpenShell \
--pattern "$ASSET" --dir "$tmpdir"
GH_TOKEN="${GITHUB_TOKEN:-}" gh release download --repo NVIDIA/OpenShell \
--pattern "$CHECKSUM_FILE" --dir "$tmpdir"
else
curl -fsSL "https://github.com/NVIDIA/OpenShell/releases/latest/download/$ASSET" \
-o "$tmpdir/$ASSET"
curl -fsSL "https://github.com/NVIDIA/OpenShell/releases/latest/download/$CHECKSUM_FILE" \
-o "$tmpdir/$CHECKSUM_FILE"
fi

info "Verifying SHA-256 checksum..."
(cd "$tmpdir" && grep -F "$ASSET" "$CHECKSUM_FILE" | shasum -a 256 -c -) \
|| fail "SHA-256 checksum verification failed for $ASSET"

tar xzf "$tmpdir/$ASSET" -C "$tmpdir"

target_dir="/usr/local/bin"
Expand Down
6 changes: 6 additions & 0 deletions test/runner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,5 +293,11 @@ describe("regression guards", () => {
expect(line.includes("NVIDIA_API_KEY")).toBe(false);
}
});

it("install-openshell.sh verifies OpenShell binary checksum after download", () => {
const src = fs.readFileSync(path.join(import.meta.dirname, "..", "scripts", "install-openshell.sh"), "utf-8");
expect(src).toContain("openshell-checksums-sha256.txt");
expect(src).toContain("shasum -a 256 -c");
});
});
});
Loading