Skip to content

test(e2e): avoid repeated Jetson workflow validation - #6879

Merged
cv merged 1 commit into
mainfrom
codex/optimize-jetson-workflow-boundary
Jul 14, 2026
Merged

test(e2e): avoid repeated Jetson workflow validation#6879
cv merged 1 commit into
mainfrom
codex/optimize-jetson-workflow-boundary

Conversation

@cv

@cv cv commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Jetson workflow mutation tests now validate the runner-dispatch boundary in memory instead of serializing a 249 KB workflow and running the full aggregate validator for every mutation. This keeps e2e-support in the combined CLI coverage shards while removing the operation that exceeded the five-second test budget under CI contention.

Changes

  • Add validateJetsonRunnerDispatchBoundary as the shared consumer of the existing Jetson workflow input, selector, routing, and guard checks; the aggregate E2E workflow validator continues to invoke it.
  • Route focused Jetson mutations through that in-memory boundary instead of temporary YAML files and repeated whole-workflow validation. The current requirement is the combined coverage shard introduced in ci: consolidate hermetic Vitest lanes #6857, and jetson-workflow-boundary.test.ts protects the direct and aggregate validator paths.
  • Leave artifact-upload and Docker-auth cleanup contracts with their dedicated validators and tests rather than duplicating those cross-cutting assertions in the Jetson dispatch test.
  • Reduce the previously failing coverage-mode mutation from 1.35 seconds to 118 milliseconds locally.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: Internal test-harness optimization; no CLI behavior, workflow behavior, contributor command, or user-facing contract changes.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: No runtime runner path changed. The aggregate validator still invokes the same Jetson input, selector, routing, and dispatch-guard checks, and the complete E2E support suite passes.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project e2e-support: 116 files and 1,000 tests passed; focused CI-style V8 coverage run: 3 tests passed and the mutation completed in 118 ms.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Tests

    • Updated end-to-end workflow validation to check Jetson GPU dispatch boundaries directly and consistently.
    • Refined expected validation results to focus on runner queue settings and dispatch guard ordering.
  • Refactor

    • Consolidated workflow boundary checks, reducing duplicate validation paths and improving test reliability.

@cv cv self-assigned this Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 50758f08-f7ea-4739-941c-160bce552caf

📥 Commits

Reviewing files that changed from the base of the PR and between cf04a13 and 41408a0.

📒 Files selected for processing (2)
  • test/e2e/support/jetson-workflow-boundary.test.ts
  • tools/e2e/workflow-boundary.mts

📝 Walkthrough

Walkthrough

Jetson workflow boundary validation is centralized in a new exported helper. E2E mutation tests now validate in-memory workflows directly, and the expected guard-error list is narrowed.

Changes

Jetson boundary validation

Layer / File(s) Summary
Centralize Jetson boundary validation
tools/e2e/workflow-boundary.mts
Adds an exported validator combining dispatch input and runner guard checks, and routes the full workflow validator through it without duplicate validation.
Rewire mutation tests
test/e2e/support/jetson-workflow-boundary.test.ts
Validates mutated workflows in memory and removes obsolete filesystem/YAML handling; narrows the expected guard errors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: area: e2e, chore

Suggested reviewers: ericksoa, apurvvkumaria

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: reducing repeated Jetson workflow validation in E2E tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-jetson-workflow-boundary

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the main branch.

TypeScript / code-coverage/cli

The overall coverage in the codex/optimize-jetso... branch remains at 79%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.
File main 20130dd codex/optimize-jetso... 41408a0 +/-
src/lib/state/m...-acquisition.ts 89% 82% -7%
src/lib/adapters/http/probe.ts 94% 97% +3%
src/lib/messagi.../persistence.ts 86% 89% +3%
src/lib/onboard...eway-process.ts 90% 93% +3%
src/lib/sandbox...rce-identity.ts 89% 94% +5%
src/lib/adapter...shell/client.ts 83% 88% +5%
src/lib/messagi...l-validation.ts 70% 77% +7%
src/lib/onboard...licy-presets.ts 81% 100% +19%
src/lib/messagi...onfig-parser.ts 62% 92% +30%
src/lib/hermes-dashboard.ts 63% 95% +32%

Updated July 14, 2026 17:44 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Failed

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-onboard, credential-sanitization, security-posture

1 optional E2E recommendation
  • jetson-nvmap-gpu

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@cv
cv merged commit 6efb6f0 into main Jul 14, 2026
80 of 82 checks passed
@cv
cv deleted the codex/optimize-jetson-workflow-boundary branch July 14, 2026 17:47
@coderabbitai coderabbitai Bot mentioned this pull request Jul 14, 2026
21 tasks
@wscurran wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure platform: jetson Affects Jetson AGX Thor or Orin labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure platform: jetson Affects Jetson AGX Thor or Orin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants